Change volumes number and year to integers

mwean · Sep 18, 2013 · 5cfb389 · 5cfb389
1 parent 90ebec2
commit 5cfb389
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 13 deletions.
diff --git a/app/admin/volume.rb b/app/admin/volume.rb
@@ -2,7 +2,7 @@
   config.filters = false
 
   index download_links: false do
-    column :number, sortable: :number
+    column :number
     column :year
     column 'ISBN', :isbn
     default_actions

diff --git a/app/controllers/volumes_controller.rb b/app/controllers/volumes_controller.rb
@@ -2,6 +2,6 @@ class VolumesController < ApplicationController
   respond_to :html
 
   def index
-    @volumes = Volume.sort_by_number_desc.decorate
+    @volumes = Volume.order('number DESC').decorate
   end
 end
diff --git a/app/models/volume.rb b/app/models/volume.rb
@@ -3,12 +3,4 @@ class Volume < ActiveRecord::Base
 
   validates :number, presence: true
   validates :year, presence: true
-
-  def self.sort_by_number_asc
-    reorder('CAST(volumes.number AS INTEGER) ASC')
-  end
-
-  def self.sort_by_number_desc
-    reorder('CAST(volumes.number AS INTEGER) DESC')
-  end
 end
diff --git a/db/migrate/20130903025247_create_volumes.rb b/db/migrate/20130903025247_create_volumes.rb
@@ -1,9 +1,9 @@
 class CreateVolumes < ActiveRecord::Migration
   def change
     create_table :volumes do |t|
-      t.string :number
-      t.string :year
-      t.string :isbn
+      t.integer :number
+      t.integer :year
+      t.string  :isbn
 
       t.timestamps
     end