FIX: Enable xticklabels for all bottom axes #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaozGelbart
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3600 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 75 75
Lines 24701 24712 +11
=======================================
+ Hits 24336 24348 +12
+ Misses 365 364 -1
|
mwaskom
reviewed
Dec 28, 2023
| if not _version_predates(mpl, "3.7"): | ||
| assert ax.xaxis.get_tick_params()["labelleft"] | ||
| else: | ||
| assert len(ax.get_xticklabels()) > 0 |
There was a problem hiding this comment.
I'm confused about how this is flagged as not tested since the pinned build log appears to have matplotlib 3.4 installed.
There was a problem hiding this comment.
Unsure about this comment by codecov, but its webpage for this test suite suggests it is tested (lines marked as green). See here.
There was a problem hiding this comment.
Agreed, the full code coverage report looks fine, not sure what's up with the bot.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, wrapped faceted plots (with shared axis) are created by deletion of some axes from a larger rectangular grid, so axes that are not on the bottom row lose their tick labels. Current code makes sure that all xtick labels are visible, but doesn't ensure that they're on. The proposed PR makes sure all "bottom" axes have their xticklabels on.
Fixes #3548 :