fix(jvmId): correct query for Targets with null jvmId (cryostatio#496)

mwangggg · Jun 6, 2024 · 2d1a768 · 2d1a768
1 parent 836fa91
commit 2d1a768
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 13 deletions.
diff --git a/src/main/java/io/cryostat/discovery/Discovery.java b/src/main/java/io/cryostat/discovery/Discovery.java
@@ -229,8 +229,7 @@ public Response register(@Context RoutingContext ctx, JsonObject body)
             // check if a plugin record with the same callback already exists. If it does,
             // ping it:
             // if it's still there reject this request as a duplicate, otherwise delete the
-            // previous
-            // record and accept this new one as a replacement
+            // previous record and accept this new one as a replacement
             DiscoveryPlugin.<DiscoveryPlugin>find("callback", unauthCallback)
                     .singleResultOptional()
                     .ifPresent(

diff --git a/src/main/java/io/cryostat/targets/Target.java b/src/main/java/io/cryostat/targets/Target.java
@@ -55,6 +55,8 @@
 import jakarta.persistence.Entity;
 import jakarta.persistence.EntityListeners;
 import jakarta.persistence.JoinColumn;
+import jakarta.persistence.NamedQueries;
+import jakarta.persistence.NamedQuery;
 import jakarta.persistence.OneToMany;
 import jakarta.persistence.OneToOne;
 import jakarta.persistence.PostPersist;
@@ -73,6 +75,7 @@
 
 @Entity
 @EntityListeners(Target.Listener.class)
+@NamedQueries({@NamedQuery(name = "Target.unconnected", query = "from Target where jvmId is null")})
 public class Target extends PanacheEntity {
 
     public static final String TARGET_JVM_DISCOVERY = "TargetJvmDiscovery";
@@ -319,9 +322,9 @@ void onMessage(TargetDiscovery event) {
 
         @ConsumeEvent(value = Credential.CREDENTIALS_STORED, blocking = true)
         @Transactional
+        @Blocking
         void updateCredential(Credential credential) {
-            Target.<Target>find("jvmId", (String) null)
-                    .list()
+            Target.<Target>stream("#Target.unconnected")
                     .forEach(
                             t -> {
                                 try {
@@ -360,15 +363,19 @@ void prePersist(Target target) {
 
         @Blocking
         private void updateTargetJvmId(Target t, Credential credential) {
-            t.jvmId =
-                    connectionManager
-                            .executeDirect(
-                                    t,
-                                    Optional.ofNullable(credential),
-                                    JFRConnection::getJvmIdentifier)
-                            .map(JvmIdentifier::getHash)
-                            .await()
-                            .atMost(timeout);
+            try {
+                t.jvmId =
+                        connectionManager
+                                .executeDirect(
+                                        t,
+                                        Optional.ofNullable(credential),
+                                        JFRConnection::getJvmIdentifier)
+                                .map(JvmIdentifier::getHash)
+                                .await()
+                                .atMost(timeout);
+            } catch (Exception e) {
+                logger.error(e);
+            }
         }
 
         @PostPersist