Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tailwindcss as devDependency #9

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: tailwindcss as devDependency #9

merged 1 commit into from
Feb 5, 2024

Conversation

felixgeissler
Copy link
Contributor

This line requires tailwindcss to be installed as a dependency rather than a devDependency:

const plugin = require('tailwindcss/plugin')

Yarn check packages with their imports and corresponding package.json entrys. This PR will make
tailwindcss-safe-area work again with Yarn projects.

@felixgeissler
Copy link
Contributor Author

felixgeissler commented Feb 4, 2024

Fixes #8

@mvllow
Copy link
Owner

mvllow commented Feb 5, 2024

Thank you for the PR, that makes sense to not be a dev dependency. I've never used peer dependencies, personally, but I'm curious if this would be better as a peer instead? Perhaps we can say we need any working range of tailwindcss instead of including a potentially different version with this plugin.

@felixgeissler
Copy link
Contributor Author

Good idea! I updated the package to be a peerDependency. I wonder though what the lowest possible version is. I would say supporting >=3.0.0 for now and investigating earlier versions on demand should be a good start.

package.json Outdated Show resolved Hide resolved
@mvllow mvllow merged commit 6757654 into mvllow:main Feb 5, 2024
@mvllow
Copy link
Owner

mvllow commented Feb 5, 2024

Thank you! Appreciate the revisions :)

@felixgeissler
Copy link
Contributor Author

Happy to help 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants