Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assessment create does not handle new tags (only existing ones) #23

Closed
mvillis opened this issue Dec 18, 2015 · 6 comments
Closed

assessment create does not handle new tags (only existing ones) #23

mvillis opened this issue Dec 18, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@mvillis
Copy link
Owner

mvillis commented Dec 18, 2015

When you create a new assessment, if you add new tags they are not handled.
Need to fix!

@mvillis mvillis added the bug label Dec 18, 2015
@mvillis
Copy link
Owner Author

mvillis commented Jan 5, 2016

Will be waiting for this to be finished before delivering this functionality JedWatson/react-select#660

@mvillis mvillis modified the milestone: 0.5 Jan 11, 2016
@rloomans rloomans changed the title assessment create does not handle new tags (only existing one) assessment create does not handle new tags (only existing ones) Feb 29, 2016
@rloomans
Copy link
Collaborator

@mvillis did you see this comment with a workaround?

mitani commented on 6 Jan
This was a show stopper for us, but there is a workaround. For those of you that need allowCreate today - you can just use filterOptions and add an option {label: Add ${term}, value: term, create:true} and then you just process it in your onChange function where you look for create === true

@mvillis
Copy link
Owner Author

mvillis commented Mar 6, 2016

cool. will check it out.
fyi the tag api does not support the creation of tags yet.

@rloomans
Copy link
Collaborator

rloomans commented Mar 7, 2016

@mvillis It seems to... 97ebd4e

@mvillis
Copy link
Owner Author

mvillis commented Mar 13, 2016

I was expecting to have to create an api to sort through the tag options sent through as part of a team / assessment, identify any that don't exist, create them then add them to whichever relationship wants them.
We could broker this on the javascript side.....

@rloomans rloomans self-assigned this Mar 21, 2016
@rloomans
Copy link
Collaborator

Looking to use a different component, at least until the upstream PR is fixed and merged.

Eg,

@rloomans rloomans self-assigned this Mar 31, 2016
rloomans added a commit that referenced this issue Jul 15, 2019
…lugin-react-7.10.0

Bump eslint-plugin-react from 7.8.1 to 7.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants