Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlighting Bug Fixes and Features #141

Closed
wants to merge 9 commits into from

Conversation

andrewcole50
Copy link
Contributor

BUG #112

Fixed multiplication highlighted as comment
Added GOSUB, GOTO, CALL highlighting and changed MV functions from class highlighting to function highlighting.
Added EACH to the keywords to highlight "FOR EACH"
@andrewcole50 andrewcole50 changed the title Fix Multiplication highlighted as Comment Syntax Highlighting Bug Fixes and Features Mar 3, 2021
@andrewcole50
Copy link
Contributor Author

Feature #122. Also accounted for CALL along the same lines.

Added EACH as keyword for OpenQM to account for "FOR EACH"

@andrewcole50
Copy link
Contributor Author

Lastly, changed highlighting MV functions from classes to functions. I find this to be more accurate as, for example, an OCONV(x, y) is most definitely a function and NOT a class and should be highlighted as such.

@kpowick
Copy link
Member

kpowick commented Mar 3, 2021

Hi @andrewcole50,

Nice to see more hands help lighten the load. Thanks for your work.

Just a FYI. All pull requests should be for the project's develop branch. Once develop achieves stability and includes desired milestones, the changes are pulled into main for a new public release of mvExtensions.

A while back, the decision was made for the main branch to only represent the current public release of mvExtensions.

Bearing that in mind, it's probably best to set up your own repo that way, so pull requests are from your develop branch to the project's develop branch.

Again, thanks for tackling some of the open issues. The more help, the better!

@itsxallwater
Copy link
Member

Great call @kpowick!

@andrewcole50 andrewcole50 changed the base branch from main to develop March 4, 2021 13:39
@andrewcole50
Copy link
Contributor Author

@kpowick changed to develop branch.

@itsxallwater itsxallwater deleted the branch mvextensions:develop March 10, 2021 20:55
@itsxallwater itsxallwater reopened this Mar 10, 2021
@itsxallwater
Copy link
Member

Looks like this one was able to be re-opened unlike #139

@itsxallwater itsxallwater self-assigned this Mar 11, 2021
@itsxallwater
Copy link
Member

Am I correct in stating that we can close this because you have these changes also incorporated with #148?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants