Add parent submission field for reply threads #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new "parent submission" field to the default submission section, letting the user pick a submission's parent from a drop-down. After posting a submission, website services get a chance to react to this and manipulate the child's part however they feel is useful. Currently, this is implemented for Bluesky, Mastodon and Pleroma, which will set the "reply to post URL" field to the source URL of the parent post, removing the necessity to manually copy those over. Other uses could be implemented if someone feels like it, different websites have various flavors of post relationships that could be handled this way. The only time the application acts on parent-child relationships is right after a submission has been posted. That means invalid parents that reference removed submissions cause no harm, they're presented to the user as being unassigned. That means we don't need to bother maintaining the validity of these fields when removing submissions. We also don't need to check for circular dependencies, since those circles will break themselves as soon as one submission out of them is posted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new "parent submission" field to the default submission section, letting the user pick a submission's parent from a drop-down. After posting a submission, website services get a chance to react to this and manipulate the child's part however they feel is useful.
Currently, this is implemented for Bluesky, Mastodon and Pleroma, which will set the "reply to post URL" field to the source URL of the parent post, removing the necessity to manually copy those over.
Other uses could be implemented if someone feels like it, different websites have various flavors of post relationships that could be handled this way.
The only time the application acts on parent-child relationships is right after a submission has been posted. That means invalid parents that reference removed submissions cause no harm, they're presented to the user as being unassigned. That means we don't need to bother maintaining the validity of these fields when removing submissions. We also don't need to check for circular dependencies, since those circles will break themselves as soon as one submission out of them is posted.