v3.1.50 #381
Merged
v3.1.50 #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transmits an array of them, one element per file. Default field is called "alt".
The implementation is conceptually simple: it checks if we're allowed to upload video, uploads it, then polls the processing status until completion and then posts the post. What makes this difficult is that the atproto library is completely busted in three dimensions. First, the main module file contains what looks to me like a syntax error. The TypeScript compiler agrees, so you can't even compile it. The workaround is to avoid this main file and instead import stuff piecemeal instead. Then, while they allow you to specify a fetch handler, they still unconditionally access a bunch of browser-specific stuff (Request, Response, FormData) in the global scope, requiring us to jam those in there so that it's happy. Finally, the implementation of the video endpoints in the API is plain wrong, missing required arguments (that you can't specify anyway because then validation fails), not requesting the required access tokens and hitting the wrong endpoint altogether. So we instead punt to manual fetching in the same way that the website does.
…into telegram-groups-support
Add Bluesky video support
Support alt text for custom website
Telegram: support groups
…rt patreon / sstar (#380) * feat: allow support for images inserted into the text mostly to support patreon / sstar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.