-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New setting: Close on quit #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to hear your opinion on the listener comment.
nits are non-blockers.
electron-app/src/main.ts
Outdated
}); | ||
notification.show(); | ||
}, 750); | ||
if (!global.settingsDB.getState().quitOnClose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the 'closed' event listener's instantiation shouldn't be affected by the setting. It would be better to just stick the 'if' inside and do an app quit when true. This would support better behavior imo and would allow the app to instantly take any updates to the setting into account when the user then closes the window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats right! I will update that
/> | ||
</Form.Item> | ||
<p> | ||
To use scheduling feature, this settings <strong>must be</strong> disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: technically untrue as the app could still post as long as the window was minimized, although I understand the purpose. Probably fine to keep as is for now or just suggest that it is recommended to disable when using scheduled posts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
@mvdicarlo All done! Thanks for you review |
Feature request: https://discord.com/channels/395931304870281216/395933121981317120/1280074401701691453
Also slightly reworked global.d.ts to properly add types to global