Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Description Length Limit #264

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

Kelketek
Copy link
Contributor

This PR adds a check for descriptions which exceed the 2000 character limit imposed by Artconomy, providing an error when present.

Testing instructions:

  1. Log into an Artconomy account
  2. Create a file submission
  3. Enter a default description with a length over 2000 characters
  4. Verify error message shown upon save
  5. Replace default description with one that is shorter than 2000 characters
  6. Add a description override for Artconomy with a length greater than 2000 characters
  7. Verify error message shown upon save

@askmeaboutlo0m
Copy link
Contributor

The description validation check is incorrect, it just grabs the description in HTML format and uses its length. Compare with how other website services do it.

@Kelketek Kelketek force-pushed the fox/artconomy-caption-limit branch from 1e563f7 to c8c7a3b Compare October 19, 2023 11:54
@Kelketek
Copy link
Contributor Author

Thanks, @askmeaboutlo0m ! That solution is also far more concise. I've updated the code.

@mvdicarlo mvdicarlo merged commit 655dbe9 into mvdicarlo:develop Oct 20, 2023
@Kelketek Kelketek deleted the fox/artconomy-caption-limit branch February 2, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants