Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker token #902

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Use docker token #902

merged 2 commits into from
Jul 19, 2022

Conversation

fauust
Copy link
Collaborator

@fauust fauust commented Jul 19, 2022

See: peter-evans/dockerhub-description#10

Not mandatory but good to implement IMO:

  1. create a Docker Hub token (needs read/write/delete rights)
  2. replace DOCKER_PASSWORD with DOCKER_TOKEN in GH actions secrets.
  3. eventually add 2FA authentication on Docker Hub (it was not possible because of that).

@fauust fauust requested a review from mvdan July 19, 2022 10:30
@mvdan
Copy link
Owner

mvdan commented Jul 19, 2022

Thanks for this! I actually tried to make DOCKER_PASSWORD into a token in 2020, but then the "update description" action started failing, so we reverted to my actual password: #492 (comment)

More than happy to give this another try. In the process, I'll change the current password and create an entirely new token. I also think that using a different env var name will indeed help to clarify that it's a token and not a password.

As with all these things, we'll do the final test by merging and seeing what happens :)

@mvdan
Copy link
Owner

mvdan commented Jul 19, 2022

Passwords and tokens reset, 2FA enabled, new token created, old password secret deleted, new token secret created. Pulling the trigger; we'll see if anything breaks.

@mvdan mvdan merged commit af30e3f into mvdan:master Jul 19, 2022
@mvdan
Copy link
Owner

mvdan commented Jul 19, 2022

Looks like it all went well: https://github.com/mvdan/sh/runs/7411624808?check_suite_focus=true

Thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants