syntax: properly tokenize ) after a test regexp

We weren't consuming its rune, which could lead to us seeing duplicate "right parenthesis" tokens. In the added test case, this resulted in an incorrect syntax error. Fixes #470.
mvdan · Jan 3, 2020 · c11932a · c11932a
1 parent 23f86c8
commit c11932a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/syntax/lexer.go b/syntax/lexer.go
@@ -317,6 +317,7 @@ skipSpace:
 			} else {
 				p.tok = rightParen
 				p.quote = noState
+				p.rune() // we are tokenizing manually
 			}
 		default: // including '(', '|'
 			p.advanceLitRe(r)

diff --git a/syntax/printer_test.go b/syntax/printer_test.go
@@ -374,6 +374,7 @@ var printTests = []printCase{
 	samePrint("case a in b) [[ x =~ y ]] ;; esac"),
 	samePrint("case a in b) [[ a =~ b$ || c =~ d$ ]] ;; esac"),
 	samePrint("case a in b) [[ a =~ (b) ]] ;; esac"),
+	samePrint("[[ (a =~ b$) ]]"),
 	{
 		"a=(\nb\nc\n) b=c",
 		"a=(\n\tb\n\tc\n) b=c",