Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ref forwarding #54

Merged
merged 4 commits into from
Apr 5, 2021
Merged

Support ref forwarding #54

merged 4 commits into from
Apr 5, 2021

Conversation

CharlieHess
Copy link
Contributor

This lets users hook a ref to the inner div for maximum flexibility. Totally backwards compatible change, too!

@vercel
Copy link

vercel bot commented Feb 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vasin/react-div-100vh/ENDKcbeZu5YxUHHYjPE3zCbC67zp
✅ Preview: https://react-div-100vh-git-fork-charliehess-patch-1-vasin.vercel.app

@mvasin
Copy link
Owner

mvasin commented Feb 19, 2021

Hey @CharlieHess, thanks for the PR!

Seems like formatting check failed (please amend the commit with yarn prettier:write) and there's something with DCO.

Also, a test would be great - but nevermind, I can add it myself.

Signed-off-by: Charlie Hess <[email protected]>
@CharlieHess
Copy link
Contributor Author

hi @mvasin, sorry for the delay. to get this passing I had to disable some react lint rules. I'm not sure why you'd need to validate prop-types in a TypeScript component, and the display-name wasn't set before, either. so I think the current master would not pass these lint rules either.

@mvasin
Copy link
Owner

mvasin commented Apr 5, 2021

Thanks for the PR, @CharlieHess! I added a test and the display name.

@CharlieHess CharlieHess deleted the patch-1 branch April 5, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants