Aio fixes #735
Merged
Aio fixes #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
=========================================
+ Coverage 89.02% 89.1% +0.07%
=========================================
Files 61 63 +2
Lines 4646 4725 +79
Branches 818 822 +4
=========================================
+ Hits 4136 4210 +74
- Misses 332 337 +5
Partials 178 178
|
vdboor
force-pushed
the
aio-fixes
branch
2 times, most recently
from
dc71783 to
938fae6
Compare
Tornado 5.x starts it's own event loop, breaking other packages: jupyter/notebook#3397 http://www.tornadoweb.org/en/stable/releases/v5.0.0.html#backwards-compatibility-notes
The zeep WSDL loading is not asynchronous yet, calling it from a coroutine doens't work yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session.close()The latest zeep still breaks on Tornado 5.x, since Tornado 5 already starts a asyncio loop.