try our hand at editing some next configs #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heff
reviewed
Aug 29, 2023
| } else if (e.error === 'already_added') { | ||
| changes.push([log.info, 'It seems like next-video is already added to your Next Config']); | ||
| } else { | ||
| changes.push([log.error, 'Failed to update next.config.js, please add next-video to your config manually.']); |
There was a problem hiding this comment.
When we have the "manual install guide" we should add a link to that here.
src/cli/lib/next-config.ts
Outdated
| const COMMON_TEMPLATE = ` | ||
|
|
||
| // Everything below here added by the ${PACKAGE_NAME} CLI wizard. | ||
| // You should probably clean this up. |
There was a problem hiding this comment.
I think this is pretty creative. Does your average next.js user actually care, or should this be more like "feel free to clean this up"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets weird, but it was a common request for us to just shoot our next config shot. So here you go.