testing "fun" #34
Merged
testing "fun" #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heff
approved these changes
Aug 24, 2023
tests/cli.test.ts
Outdated
| assert(findConsoleMessage(warningSpy, /Directory does not exist/i), 'Directory does not exist message not found'); | ||
| assert( | ||
| findConsoleMessage(infoSpy, /Did you forget to run next-video init/i), | ||
| 'Did you forget to run next-video init message not found' |
There was a problem hiding this comment.
Not a blocker, but might make sense to store the text as constants somewhere, so changes to the text don't have to be made in two places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI is getting complex enough that we should be testing already, but definitely if we're going to do things like the crazy pants stuff in #33.