Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading of next.config.ts for next-video CLI #314

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

luwes
Copy link
Collaborator

@luwes luwes commented Oct 30, 2024

this fixes an issue with loading the video config for the next-video CLI commands.

we used to load (import) the next config files directly so that the next-video config would also be set via withNextVideo but now with the introduction of next.config.ts it involves a transpile step. with this change we offload this work to the function loadConfig in next/dist/server/config which handles the TS conversion...

@luwes luwes self-assigned this Oct 30, 2024
Copy link

height bot commented Oct 30, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-video-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 10:00pm

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (ae99a8b) to head (bbfe19c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #314      +/-   ##
==========================================
- Coverage   89.22%   89.19%   -0.04%     
==========================================
  Files          32       32              
  Lines        2562     2554       -8     
  Branches      337      343       +6     
==========================================
- Hits         2286     2278       -8     
  Misses        275      275              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luwes luwes merged commit 728406a into muxinc:main Oct 31, 2024
8 checks passed
@luwes luwes deleted the fix-load-config branch October 31, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants