Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix custom player types + add react-player example #242

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

luwes
Copy link
Collaborator

@luwes luwes commented Apr 19, 2024

fixed a react-player issue in cookpete/react-player#1775

@luwes luwes self-assigned this Apr 19, 2024
Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-video-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 7:30pm

@luwes luwes force-pushed the custom-player-example branch from d5bf9bb to 47a8482 Compare April 19, 2024 18:10
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (3efcbbb) to head (2279309).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   90.62%   90.60%   -0.02%     
==========================================
  Files          30       30              
  Lines        2410     2406       -4     
  Branches      338      336       -2     
==========================================
- Hits         2184     2180       -4     
  Misses        226      226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luwes luwes force-pushed the custom-player-example branch from 47a8482 to c381613 Compare April 19, 2024 18:18
@luwes luwes changed the title example: add custom player. react-player fix: fix custom player types + add react-player example Apr 19, 2024
@luwes luwes force-pushed the custom-player-example branch from 184532d to 2279309 Compare April 19, 2024 19:29
@luwes luwes merged commit 6895a1b into muxinc:main Apr 19, 2024
6 checks passed
@luwes luwes deleted the custom-player-example branch April 19, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants