-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import next.config.js in Windows #159
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 57.94% 58.43% +0.49%
==========================================
Files 29 30 +1
Lines 2166 2216 +50
Branches 110 120 +10
==========================================
+ Hits 1255 1295 +40
- Misses 909 916 +7
- Partials 2 5 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one suggestion
related #151
it's fixed, the issue seems to be that Windows path.resolve() behaves differently than Unix.
it did require a cwd() argument while Unix didn't it seemed.
path.resolve(cwd(), file);
I also added
pathToFileURL
to make sure it's a valid URL for JS dynamic import() because it expects an URL, not a path.nodejs/node#34765