Docs/styling guide #588
Merged
Docs/styling guide #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cjpillsbury
force-pushed
the
docs/styling-guide
branch
from
422bd88
to
83f22df
Compare
Codecov Report
@@ Coverage Diff @@
## main #588 +/- ##
=======================================
Coverage 77.64% 77.64%
=======================================
Files 43 43
Lines 8006 8006
=======================================
Hits 6216 6216
Misses 1790 1790 |
cjpillsbury
force-pushed
the
docs/styling-guide
branch
from
9175d85
to
26e4623
Compare
davekiss
reviewed
May 11, 2023
davekiss
reviewed
May 11, 2023
davekiss
reviewed
May 11, 2023
davekiss
reviewed
May 11, 2023
davekiss
reviewed
May 11, 2023
…ithout additional effort.
cjpillsbury
force-pushed
the
docs/styling-guide
branch
from
e524687
to
3b2552c
Compare
davekiss
reviewed
May 11, 2023
davekiss
reviewed
May 11, 2023
davekiss
approved these changes
May 11, 2023
There was a problem hiding this comment.
It's no small feat to write a helpful, interactive, lean, and comprehensive styling guide for a whole stinkin' lib, killer work @cjpillsbury 🛳️
Co-authored-by: Dave Kiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working version here: https://media-chrome-docs-git-fork-cjpillsbury-docs-styling-guide-mux.vercel.app/en/styling
First pass on a styling guide.
I dropped the external svg example (
<svg><use href="#ref"></use></svg>) because, although it works, there was not a clean way to include it in sandpack, and the most recent plan (host externally) also has issues.Time permitting, I'd like to also add a section on Styling + WCAG / A11Y, but wanted to make sure we get through any remaining planned updates before expanding on scope even more.