Update 'isServer' to also check for customElements #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mux/media-chrome/Fe5hofZXBeht4vDwfqZUUeawyg4V |
mmcc
approved these changes
Jun 24, 2021
heff
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Seems fine to try and see what happens, but this could break whatever was relying on the other window shim by overriding it with ours, unless the other shim is just a blank object.
If we run into an issue here we could separate shimming the window and shimming custom elements, so that custom elements get added to any existing window shim (or our window shim if needed).
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments there are preexisting
windowshims that do not have thecustomElementson the window object. This update will check for those cases.See: sanity-io/sanity-plugin-mux-input#36 (comment)