Removing warning if NSAssert is undefined #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling the 1.2 release into the fork
- Providing a init method for MMWormholeFileTransiting because inheriting from NSObject requires it now.
Closed
|
Thank you for this! I ended up pulling it in as part of the watchOS branch, so I'm going to close the PR. It'll be merged in as part of the 1.3.0 milestone. Thanks again! |
|
Sure no problem. Glad it was helpful, and thank you for providing MMWormhole in the first place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new checkAppGroupCapabilities function creates a NSURL and then uses it in a NSAssert macro. If NS_BLOCK_ASSERTIONS is defined (as it is in a release or beta build) then NSAssert is a no-op and you get a warning about the unused variable. This change only creates the NSURL if NSAssert is going to use it, and therefore removes the warning on builds without NSAssert.