fix(hook): sequential updater calls operate on latest state #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hola! I found what I think is a 🐛 bug where multiple
setState()
calls fromuseMutative()
both operate on the initial state, which can lead to unexpected dropped data. Here's a somewhat forced example:Once the next render happens,
state.items
would be[1, 3]
(only the last call is applied), instead of the cumulative[1, 2, 3]
.A fix
This PR changes how the hook's
updateState()
function is defined so that it uses the callback form of ReactsetState
so that each invocation ofuseMutative
operates on the latest/up-to-date draft. Added a new test to verify the behavior :)This also has a nice side-effect of making the
updateState()
callback identity stable, so it doesn't change between renders (although maybe it should whenoptions
changes?).