Refactor #13
Merged
Refactor #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld setup structure for repeatable properly.
…rl versions (and busting cache for version releases)
mustardBees
added a commit
that referenced
this pull request
Feb 4, 2015
Refactor to use CMB2 APIs. No longer need sanitization_cb, and should setup structure for repeatable properly.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Phil, I finally got a chance to install and play with this field type. It's pretty nifty, but the field callbacks could be leveraging the CMB2 objects quite a bit more. This PR refactors them to use those tools. Please ask me any questions you have about how/why I did things.