Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add canonicalized v4 #20

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Conversation

bwbohl
Copy link
Member

@bwbohl bwbohl commented Mar 14, 2018

As of today's music-encoding status, from commit bwbohl/music-encoding@0b57610

As of today's music-encoding status, from commit bwbohl/music-encoding@0b57610
@bwbohl
Copy link
Member Author

bwbohl commented Mar 14, 2018

sorry, something got in between :-/

@bwbohl
Copy link
Member Author

bwbohl commented Mar 14, 2018

ok there's a problem with duplicate classSpec att.fing.ges

@bwbohl
Copy link
Member Author

bwbohl commented Mar 14, 2018

even after commenting out one of the duplicate classSpecs the transformation fails due to a referenced att.fingGrp.ges not being defined.

@bwbohl
Copy link
Member Author

bwbohl commented Mar 14, 2018

@pe-ro any ideas?

@lpugin lpugin merged commit b1afa8f into music-encoding:master Mar 15, 2018
@lpugin
Copy link
Member

lpugin commented Mar 16, 2018

Another issue: I do not think the file contains the narrative of the guidelines. Please double check.

@bwbohl
Copy link
Member Author

bwbohl commented Mar 16, 2018

oh, gotta check on that I thought that was coming automatically…
I got it included though I was wondering where the linkAlign chapter should go? It wasn't included in 3.0.0 although it already existed back then, it was and still is incomplete though…

@bwbohl
Copy link
Member Author

bwbohl commented Mar 16, 2018

I included the linkAlign chapter at the end of the guidelines.
Nevertheless extracting the guidelines fails on several elements due to unresolved elementSpec references etc.

  • attribute subtype from mdiv
  • attribute subtype from div
  • attribute subtype from list
  • attribute num from pad
  • attribute rhythm from verse

unable to retrieve definition of following elements in order to create a link:

  • classCode
  • componentGrp
  • unease
  • inhume
  • lyrics
  • timeline

unable to identify class in order to create link

  • model.controleventLike from tie:ident element

unable to retrieve attribute:

  • meter.sym from att.keySigDefault
  • key.pname from att.keySigDefault
  • key.accid from att.keySigDefault
  • key.mode from att.keySigDefault
  • att.timestamp.musical from tei:ident
  • att.controlevent from tei:ident
  • att.duration.musical from tei:ident
  • att.common.anl from tei:ident
  • att.duration.performed from tei:ident

an error in the specDesc creation is thrown by:

  • att.regularmethod
  • att.common.anl
  • att.intervalharmonic
  • att.harmonicfunction
  • att.meterconfirmance
  • att.ornamentaccid
  • att.reasonident
  • att.mediabounds

@lpugin
Copy link
Member

lpugin commented Mar 19, 2018

I can drop them once in MD. I did that before already, and it is quick.
777ee10
OK?

@lpugin
Copy link
Member

lpugin commented Mar 20, 2018

classCode

replaced with classDecs - see music-encoding/music-encoding@e9b0b9d

componentGrp

change to componentList - see music-encoding/music-encoding@cd39884

unease
inhume

I assume uneume and ineume replaced by nc - see music-encoding/music-encoding@f19b4dc

lyrics

changed to lg - see music-encoding/music-encoding@088149b

timeline

Dispeared ??

model.controleventLike from tie:ident element

camelCase change

meter.sym from att.keySigDefault

moved to att.meterSigDefault.log - see music-encoding/music-encoding@3454ae6

key.pname from att.keySigDefault
key.accid from att.keySigDefault
key.mode from att.keySigDefault

Probably related to this music-encoding/music-encoding@cc20180 and this music-encoding/music-encoding#434 but I can not track them.

att.timestamp.musical from tei:ident

att.timestamp.logical ? Could not find change.

att.controlevent from tei:ident

camelCase change

att.duration.musical from tei:ident

att.timestamp2.logical ? Cound not find the change

att.common.anl from tei:ident

removed

att.duration.performed from tei:ident

att.duration.gestural ? Cound not find the change

att.regularmethod
att.common.anl
att.intervalharmonic
att.harmonicfunction
att.meterconfirmance
att.ornamentaccid
att.reasonident
att.mediabounds

camelCase changes

@pe-ro : can you have a look at this?

@pe-ro
Copy link
Contributor

pe-ro commented Mar 20, 2018

I can have a look, but not until Friday.

@lpugin
Copy link
Member

lpugin commented Mar 20, 2018

No problem. Here are some fixes, we can adjust them anytime
755d5aa...e3fd05a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants