Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prompt to add support for playlist voice commands #2833

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

nikito
Copy link
Contributor

@nikito nikito commented Aug 29, 2024

Adding additional info to the prompt to teach the LLM how to handle requests to play playlists.

Adding additional info to the prompt to teach the LLM how to handle requests to play playlists.
@OzGav
Copy link
Contributor

OzGav commented Sep 1, 2024

@jozefKruszynski thoughts?

@jozefKruszynski
Copy link
Contributor

Looks pretty reasonable. I assume it's been tested by @nikito and works for him with no code changes.
We could probably also add another playlist slot to support the LLM flow also.

@nikito
Copy link
Contributor Author

nikito commented Sep 1, 2024

Looks pretty reasonable. I assume it's been tested by @nikito and works for him with no code changes. We could probably also add another playlist slot to support the LLM flow also.

Yes, tested with a few different playlists of mine. Also tried the original commands like "songs by muse" or individual song requests to ensure no regressions. 🙂

prompt/prompt.txt Outdated Show resolved Hide resolved
prompt/prompt.txt Outdated Show resolved Hide resolved
Co-authored-by: Marcel van der Veldt <[email protected]>
@nikito
Copy link
Contributor Author

nikito commented Sep 6, 2024

Seems to be working fine with the suggested changes.

Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@marcelveldt marcelveldt merged commit 831f05e into music-assistant:main Sep 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants