Display the used volume normalization mode/values instead of target

[kepstin]

Displaying the target loudness in the stream details display isn't very useful, since that's a user-configured setting and does not change depending on what is being played. In place of that number, show information about what volume normalization is currently being applied.

If measurements are available, and are being used, it will display either the track or album measured loudness depending on whether prefer_album_loudness is set.

Otherwise, it will display "Dynamic volume normalization" if loudnorm is being used in dynamic mode - or "Fixed gain correction" if fixed gain is being applied.

If no volume normalization is being applied, the loudness information row will not be displayed.

[kepstin]

This PR conflicts with the changes made in music-assistant/server#1662 - the API no longer returns the loudness or loudness_album fields.

It looks like there's also an issue regarding types in some of the comparisons - I'm checking if loudness or loudness_album are === null to see if the fields have been populated, but this check doesn't work correctly when the field is omitted (which i think makes it undefined instead of null?)

[marcelveldt]

This PR conflicts with the changes made in music-assistant/server#1662 - the API no longer returns the loudness or loudness_album fields.

Since then I patched the HA client so we could consider adding those fields back by removing that temporary patch in the serialization. I agree it would be useful to display what is being applied. In fact I invision this dialog to be much more informative at some point:

Audio source
codec/content type
sample rate, bit depth (or bitrate in case of lossy codec)
Provider
loudness measurement (if any)

Audio target/output
What kind of volume normalization is applied ?
What gain adjustment is being made to the audio (in case of volume normalization)
What filters are active ?
What sample rate and bit depth is sent to the final destination ?
Maybe also note the intermediate step in the chain where we use f32
What codec do we use to send the audio to the player ?

Maybe we should just extend the streamdetails object with extra details.
I guess we can iterate in baby steps and your contribution is a great step forward!

Let me know if you want me to reinstate the loudness measurement on the streamdetails object now before merging this one or merge this one first and then do an extra step in a new PR.

[marcelveldt]

It looks like there's also an issue regarding types in some of the comparisons - I'm checking if loudness or loudness_album are === null to see if the fields have been populated, but this check doesn't work correctly when the field is omitted (which i think makes it undefined instead of null?)

If you check for null it will also catch undefined. For now they are undefined due to that hack to fix HA-side after I changed the value type of the loudness measurement but now that HA is patched we could revert that.

EDIT: If you want to catch both undefined and null you need to check blah == null and not blah === null

[marcelveldt]

Suggested change

	let sd = streamDetails.value;
	const sd = streamDetails.value;

[OzGav]

@kepstin Is this still being progressed?

[marcelveldt]

This PR conflicts with the changes made in music-assistant/server#1662 - the API no longer returns the loudness or loudness_album fields.

These values have been restored

[OzGav]

@kepstin are you able to progress this?