Fix crash when replacing instrument via popup in instruments panel #25441
+33
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that the popup is unloaded as soon as it is closed, and it is closed as soon as the "replace instrument" dialog appears. The unloading causes the popup and its content and the model of that content to be deleted. But the "onClicked" signal handler is still being executed at that point. This is (naturally) not allowed by Qt and causes a crash. Probably introduced by 95249f7; that commit fixed a mistake, but that mistake prevented the unloading, and thus the crash.
cbjeukendrup
force-pushed
the
instrumentspanel/replace_instrument_crash
branch
from
6298a54
to
9c7258f
Compare
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
|
@cbjeukendrup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that the popup is unloaded as soon as it is closed, and it is closed as soon as the "replace instrument" dialog appears. The unloading causes the popup and its content and the model of that content to be deleted. But the "onClicked" signal handler is still being executed at that point. This is (naturally) not allowed by Qt and causes a crash.
Probably introduced by 95249f7; that commit fixed a mistake, but that mistake prevented the unloading, and thus the crash.
Resolves: #25439