New features: include, workingDirectory #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muno92
requested changes
Oct 17, 2022
| @@ -40,6 +40,25 @@ Relative path(s) or file masks that define which files to exclude during the ins | |||
|
|
|||
| More info: https://www.jetbrains.com/help/resharper/InspectCode.html#inspection-parameters | |||
|
|
|||
| ### include | |||
With all due respect, I'm involved in a lot of projects and you're asking me to use more of my free time to maintain an additional 1-2PRs. These changes are arguably small enough to fit into 1 PR without creating too much of a burden on your end. I think FOSS is all about compromise. I thank you for allowing me to submit my changes in 1 PR which allows me the time to offer you this contribution in the first place. |
muno92
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gitattributes file
Implement support for 'include' paths or patterns
New workingDirectory input to specify cwd for the action
See README for examples / docs.