Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected some typos #260

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Corrected some typos #260

merged 1 commit into from
Nov 28, 2019

Conversation

marcorichetta
Copy link
Contributor

In the Contributors section, mumuki and 10pines links redirect to 404 pages.

In the Predicates section:

Notice: like in Mulang means that it contains that case-insensitive substring

I think this could be better explained by emphasizing the use of ~ like in the second example here

In the Contributors section, '@mumuki' and '@10Pines' links redirect to 404 pages.

In the Predicates section:
> Notice: like in Mulang means that it contains that case-insensitive substring

I think this could be better explained by emphasizing the use *~* like in the second example [here](https://mumuki.github.io/mulang/edlspec/#predicates)
Copy link
Member

@flbulgarelli flbulgarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@flbulgarelli flbulgarelli merged commit 7eec782 into mumuki:master Nov 28, 2019
@luchotc
Copy link
Contributor

luchotc commented Nov 28, 2019

@marcorichetta Thanks! Any further contributions will be appreciated 😄

@marcorichetta
Copy link
Contributor Author

By the way, I only commented the 404 links and the Predicates explanation because I wasn't sure about how to change it, but I'm willing to do it if I can.

And thank you for the incredible job.

PD: Do you know when will your Nerdearla talk be released?

@luchotc
Copy link
Contributor

luchotc commented Dec 4, 2019

Hi @marcorichetta!
Don't worry, we'll do it. Just by reporting it you are helping a lot 😄

Thanks for that comment! We were told that this month should be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants