DirectX 11 Overlay

[Kissaki]

mumble_ol.dll increased in size, from 127 to 291 KB
new dependencies: MSVCR, D3DCompiler (DLLs)
because dx11 does not include the effects anymore, the DX SDK sample effects has to be used and adapted, for compilation. By default it compiles as a static library, but thus will use libcmt, which will result in a fatal error, duplicate definition of functions. To fix this, the effects lib has to be compiled with the linker settings “ignore specific default library: LIBCMT”, and “additional dependencies: MSVCRT.lib” (added D for the debug versions).

[Kissaki]

Ok, although it worked on a sample, it crashed BFBC2 without notice. Don’t pull yet. :)

[hacst]

Wasn't the whole reason pcgod never applied this patch that it didn't work on anything but the samples?

In any case. You should override the author field of the first patch instead of putting the the source in the commit message. Much cleaner that way.

[Kissaki]

yeah

[Kissaki]

Updated. Does not crash anymore, but does not work yet neither (in dx samples neither anymore).
Still on it.

[nyetwurk]

overlay11.hex is actually overlay.hex, and your overlay.pro still has a conflict in it.

[Kissaki]

rebased
@nyetwurk: yeah, noticed I had uncommited change to use overlay.hex instead of the 11 one.

[nyetwurk]

BTW i got your branch compiling, but it crashes with EmptyProject11

[nyetwurk]

I was able to get this working by using fxc /Tfx_5_0 to generate overlay.hex

/Tfx_4_0 generates a overlay.hex that crashes CreateEffect

[nyetwurk]

Works in intro screen of bfbc2, but not the game itself (no sign of overlay)
In BF3, overlay is present, but is corrupted. It looks like the mumble overlay dll isn't getting the right screen size for rendering.
deus ex also shows NO sign of overlay at all (intro or otherwise)
dumb question: how do i get the output of the overlay log messages w/o a debugger attached to the game?

[Kissaki]

You don’t need to attach a full-fledged debugger.
Attaching windbg just for log-output should be enough.

[nyetwurk]

Got everything working on BF3.

Will test out a few other dx11 games then post the patches.

[nyetwurk]

Here are the issues

1. DX10 CreateEffect needs fx_4_0, but DX11 Create Effect needs fx_5_0.

Unfortunately, fxc outputs a header that generates a global g_main const.
So we have to have fxc output two different overlay include files, using different name spaces.

2. Most games are multithreaded, and since we dont have StateBlocks in DX11, and you have to use a DeviceContext, you can't use an ImmediateContext, you have to use a DeferredContext. Fortunately, kissaki already provided the code for it, so i just used that instead (including the CommandList code in draw()) , and bingo, everything works.

Question about the Effects library: i noticed your overlay.pro references the local directory and not the dxsdk directory. Should mumble be just copying the Effects source files as is into the repo? are there licensing issues? if there are licensing issues, then more crazy things have to be added to the build instructions.

[nyetwurk]

Works in Deus Ex, but not BFBC2.

DeferredContext creation fails.

[hacst]

@nyetwurk: That sounds great. We would love to see patches for DX11 and, given they are stable, will gladly accept them.

[pcgod]

We have to patch the Effects source files (I have a modified version somewhere) to avoid depending on a specific DirectX version, but I don't know if we can do that by checking in the Effects source or just a patch which has to be applied to the Effects source in the SDK (which would make the build instructions even more complicated)...

[nyetwurk]

https://gist.github.com/1323422

Note that this STILL doesn't help bfbc2, but at least it doesn't crash (for me)

[nyetwurk]

I verified that BFBC2 is creating the pDevice with D3D11_CREATE_DEVICE_SINGLETHREADED, so when we get the pDevice using swapchain->GetDevice(), you can't use it to create a deferred context.

Any ideas? Is there another way to create a DeferredContext other than from the SwapChain's pDevice?

[Kissaki]

Awesome to see some progress here.
Stupid that I was checking against BC2 back when I was trying it out. Maybe with a working game my interest would not have dropped as much back then :P

[nyetwurk]

I could use your help; I'm way out of my depth. Is it really necessary to have the pDevice from the swapchain creation around for creating a deferred context?

Can you just make a pDevice not connected to anything to create a DeferredContext, or do you HAVE to use the one you got when you made the swapchain?

[Kissaki]

I was more fooling around than doing what I know. Applying the outdated patch to the (then) current codebase and then trying some things out (deferred context) until time ran short again.
You already figured out more than I did it seems.

[nyetwurk]

Haha ok good. I thought I was the lone noob :) Hopefully pcgod can figure it out, because I just can't figure out how to do it w/o either deferred context or save blocks.

and i hvae NO idea how to do save blocks in dx11

[nyetwurk]

Ok, on further investigation, the ImmediateContext path is definitely VERY VERY bad unless we can save/restore state. Unless we find a way to implement DX11 SaveBlocks, the ImmediateContext code should be removed...

nyetwurk@174d0db

[nyetwurk]

Now that I have BFBC2 support working, how do we move forward with the DX11 Effects code?

More junk in the build instructions, or copy DX11 Effects code into the git repo?

[Hadlock]

Any way you can make a version that works with BF3? I don't think BC2 support is a very high priority any more - my BC2 server has been empty since BF3 was released, and my BF3 servers + mumble server are completely full all the time now.

[nyetwurk]

The dx11 branch works in bf3.. its just a bit tricky to build.

[Kissaki]

Today I tried out nyets installer he compiled, and the overlay worked in BC2.
It didn’t work for my self-compile from this branch though; but I couldn’t even install dx SDK …

[yackushevas]

Unfortunately the overlay does not work in the game The Secret World (if you use DirectX11).
Forgive me if I am not writing to the theme with the problem

[Kissaki]

So you compiled this dx11 branch yourself and tried it?

[yackushevas]

Unfortunately, I do not know how to do it. Why can not I enter this code into the mainline?

[nyetwurk]

My precompiled DX11 binaries are here:

https://github.com/nyetwurk/mumble/downloads

[Jinx1337]

The file is missing?

I can't download it?
Please reupload, I've been googling high and low for this!

[nyetwurk]

Re-uploaded. Try now

[Kissaki]

dD0T: Kissaki: http://msdn.microsoft.com/en-us/library/windows/desktop/bb509633%28v=vs.85%29.aspx#compiling_with_d3dcompilefromfile sounds like the right place to start
dD0T: Kissaki: http://gamedev.stackexchange.com/questions/17602/what-happened-to-fx-files-in-d3d11 << Seems helpful too
dD0T: "A pointer to uncompiled shader data; either ASCII HLSL code or a compiled effect." << I guess .fx is a "compiled effect"?
https://blogs.msdn.com/b/chuckw/archive/2012/05/07/hlsl-fxc-and-d3dcompile.aspx?Redirected=true

[Kissaki]

To keep any followers updated: I plan to commit all non-effects11 changes to master soon(ish) (after some other PRs).
Then we have a useful commited baseline.
Then the necessary adjustments can be done to drop effects11.

[nyetwurk]

necro pull request! Glad to see progress again. Thanks, Kissaki. Got tired of pulling/merging/rebuilding quite some time ago...

[Kissaki]

Closed in favor of a rebase with selected commits/changes.