Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let mumax3-convert convert wildcards if needed #82

Merged
merged 1 commit into from
Oct 28, 2016

Conversation

JeroenMulkers
Copy link
Collaborator

Let Mumax3-convert expand wildcards which are not expanded by the shell.
(pointing a finger at cmd.exe)

@godsic
Copy link
Contributor

godsic commented Oct 28, 2016

Have you tested on both Linux and Windows?

@JeroenMulkers
Copy link
Collaborator Author

I do not have a Windows machine, but I cross compiled mumax3-convert for Windows and tested in Wine.

I also tested the modification on linux. Following commands, give the same output:

mumax3-convert -png *.ovf
mumax3-convert -png "*.ovf"

@godsic godsic merged commit fb6b633 into master Oct 28, 2016
@godsic godsic deleted the feature/wildcardexpansion branch October 28, 2016 14:24
@gen-xu
Copy link

gen-xu commented Oct 29, 2016

I have tested wildcard on Windows 10 and it works.
Another comment: is it possible to use cuda to do the convert?

@JeroenMulkers
Copy link
Collaborator Author

The gpu can't read or write files. So I doubt that using cuda in mumax3-convert will speed up the conversion much, if any at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants