Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The magnetoelastic energy is written as:
And the effective field is:$B_{me} = -\nabla_{m} E_{me}$ $m_x$ would be:
Therefore, for example, the effective field in
The article: https://doi.org/10.12688/openreseurope.13302.1 on page 4, equation 3, explains how the model is implemented and in this GitHub link you can find the code: https://github.com/Fredericvdv/Magnetoelasticity_MuMax3/blob/eeb112dff216a4ae3267fc27fe67aa0e7ada6423/cuda/magnetoelasticfield.cu
In this repository effective field terms are calculated correctly:
Where the 2.0f is multiplied by both B1 and B2.
However, in the MuMax3 repository, I found:
The parenthesis should be after the 2.0f.
This Pull Request is to address this issue.