Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift() only exists for X-axis #337

Open
4 tasks
JonathanMaes opened this issue Oct 11, 2024 · 0 comments
Open
4 tasks

Shift() only exists for X-axis #337

JonathanMaes opened this issue Oct 11, 2024 · 0 comments

Comments

@JonathanMaes
Copy link
Contributor

Currently, only the Shift(x) command can be used in input scripts, which shifts the magnetization along the X axis. Internally, shifts along Y and Z exist, but these are only used in a select few internal functions.
If someday we wish to add support for shifting along all coordinate axes, we should:

  • Create ShiftMagF and ShiftMagB, storing the front (+z) and back (-z) inserted magnetization.
  • Implement cuda/shiftedgecarryz.cu.
  • Add Z direction to engine/shift.go and expose ShiftX(), ShiftY() and ShiftZ() for input scripts. ShiftX() is redundant as it is identical to Shift(), but Shift() has to stay for backwards compatibility.
  • Expose TotalShiftY and create TotalShiftZ. Ideally, TotalShift would be a vector, but that would break backwards compatibility, so keep TotalShift the same and add a redundant TotalShiftX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant