Feature/fudgeShift #316
Merged
Feature/fudgeShift #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new shift mode, that copies the values at the border cells when shifting the magnetisation instead of using the values stored in ShiftMagL/R. Modified functions: engine.Shift new functions: cuda.ShiftFudgeX, cuda.ShiftFudgeY (and related .cu, .ptx files).
Adds a new shift mode, that copies the values at the border cells when shifting the magnetisation instead of using the values stored in ShiftMagL/R. Modified functions: engine.Shift new functions: cuda.ShiftFudgeX, cuda.ShiftFudgeY (and related .cu, .ptx files).
Adds a new shift mode, that copies the values at the border cells when shifting the magnetisation instead of using the values stored in ShiftMagL/R. Modified functions: engine.Shift new functions: cuda.ShiftFudgeX, cuda.ShiftFudgeY (and related .cu, .ptx files).
Adds a new shift mode, that copies the values at the border cells when shifting the magnetisation instead of using the values stored in ShiftMagL/R. Modified functions: engine.Shift new functions: cuda.ShiftFudgeX, cuda.ShiftFudgeY (and related .cu, .ptx files).
Tests fudgeShift, a new shift mode that copies the values at the border cells when shifting the magnetisation instead of using the values stored in ShiftMagL/R.
|
Thank you for your contribution, and apologies for the late response to your pull request. |
|
We decided to rename the boolean to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleaned-up version of pull request #221.
This change introduces a new mode for the shift the problem window. In this new mode, the values of m in the introduced cells are copied from the cells at the border, instead of the values of ShiftMagL/R (current mode). This new mode is activated by setting FudgeShift = true (false by default).
When using auto-shifting procedures (e.g. ext_centerWall), it is still necessary to set the parameters ShiftMagL/R because they're used to determine the shift direction (as is the previous behaviour).
Modifications: