Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mapping for GCP virtual machine sizes #345

Closed
goncalo-rodrigues opened this issue Jul 11, 2022 · 2 comments · Fixed by #378
Closed

Add mapping for GCP virtual machine sizes #345

goncalo-rodrigues opened this issue Jul 11, 2022 · 2 comments · Fixed by #378
Assignees
@szymonnogiec
Labels
feature New functionality gcp GCP resource good first issue

Comments

@goncalo-rodrigues
Copy link
Member

We only have mapping for general purpose compute, we're missing compute optimized and memory optimized for GCP.

Mapping is defined in https://github.com/multycloud/multy/blob/main/resources/common/vm_size.go
@goncalo-rodrigues goncalo-rodrigues added feature New functionality good first issue gcp GCP resource labels Jul 11, 2022
@szymonnogiec
Copy link
Contributor

Hi, want to work on this next

@goncalo-rodrigues
Copy link
Member Author

Perfect, I'll assign it to you!

szymonnogiec added a commit to szymonnogiec/multy that referenced this issue Jul 24, 2022
@szymonnogiec
feat: Add compute&memory optimized GCP vm sizes
b9f3bad 
- also: add general_nano for GCP

Resolves multycloud#345
@szymonnogiec szymonnogiec mentioned this issue Jul 24, 2022
Merged
goncalo-rodrigues pushed a commit that referenced this issue Jul 25, 2022
@szymonnogiec
feat: Add compute&memory optimized GCP vm sizes (#378)
f5ea841 
- also: add general_nano for GCP

Resolves #345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonnogiec szymonnogiec

Labels
feature New functionality gcp GCP resource good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add compute&memory optimized GCP vm sizes szymonnogiec/multy
2 participants
@goncalo-rodrigues @szymonnogiec