Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate network security group resource #271

Closed
goncalo-rodrigues opened this issue May 31, 2022 · 2 comments
Closed

Validate network security group resource #271

goncalo-rodrigues opened this issue May 31, 2022 · 2 comments
Assignees
@szymonnogiec
Labels
enhancement New feature or request

Comments

@goncalo-rodrigues
Copy link
Member

@goncalo-rodrigues goncalo-rodrigues added the enhancement New feature or request label May 31, 2022
@goncalo-rodrigues goncalo-rodrigues mentioned this issue Jun 4, 2022
Open
@szymonnogiec
Copy link
Contributor

Hey, @goncalo-rodrigues please assign this to me, starting working on this now.

szymonnogiec added a commit to szymonnogiec/multy that referenced this issue Jul 25, 2022
@szymonnogiec
feat: Validate network security group resource multycloud#271
8391510 
- check that name matches azure's restrictions
- check security rules have a valid port range
- check that rules cidr block is valid
- check that rules protocol is valid
- refactor and create separate type for range validation: port range and priority
szymonnogiec added a commit to szymonnogiec/multy that referenced this issue Jul 26, 2022
@szymonnogiec
feat: Validate network security group resource multycloud#271
463f4de 
- check that name matches azure's restrictions
- check security rules have a valid port range
- check that rules cidr block is valid
- check that rules protocol is valid
- refactor and create separate type for range validation: port range and priority
goncalo-rodrigues pushed a commit that referenced this issue Jul 26, 2022
@szymonnogiec
feat: Validate network security group resource #271 (#383)
435c800 
- check that name matches azure's restrictions
- check security rules have a valid port range
- check that rules cidr block is valid
- check that rules protocol is valid
- refactor and create separate type for range validation: port range and priority
@szymonnogiec
Copy link
Contributor

@goncalo-rodrigues This can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonnogiec szymonnogiec

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goncalo-rodrigues @szymonnogiec