Integrate latest packages #359
Conversation
| @@ -78,19 +79,19 @@ def deploy(self, owner: Account, arguments: List[Any], gas_price: int, gas_limit | |||
|
|
|||
| tx = Transaction( | |||
| chain_id=chain, | |||
| sender=owner.address, | |||
| receiver=Address.from_bech32(ADDRESS_ZERO_BECH32), | |||
| sender=owner.address.to_bech32(), | |||
There was a problem hiding this comment.
Here can we use the new factory instead? Can be done now or in a next PR.
There was a problem hiding this comment.
Same for other features in contracts.py.
There was a problem hiding this comment.
Indeed. Was thinking about it, but I wanted to make sure everything works as expected. Will refactor to use the factory in a next PR.
requirements.txt
Outdated
| multiversx-sdk-core>=0.6.0,<0.7.0 | ||
| multiversx-sdk-network-providers>=0.11.0,<0.12.0 | ||
| multiversx-sdk-wallet>=0.8.0,<0.9.0 | ||
| multiversx-sdk-core==0.7.1 |
There was a problem hiding this comment.
It's good to use fixed versions, since mxpy is an end-application (not a library) 👍
Plus the fact that it's always installed within a venv (at least, this is what mxpy-up does, this is what we recommend).
There was a problem hiding this comment.
On the other hand, it's also nice to automatically benefit from hotfixes in dependencies (thus >= with < would have also worked).
There was a problem hiding this comment.
I'm a big fan of fixed versions, but I agree it's nice to benefit from hotfixes. Will indeed change to use <.
| dictionary["chainID"] = base64.b64encode(tx.chainID.encode()).decode() | ||
| dictionary["signature"] = base64.b64encode(bytes(bytearray(tx.signature))).decode() | ||
| dictionary["value"] = tx.value | ||
| dictionary: Dict[str, Any] = {} |
There was a problem hiding this comment.
Perhaps we can also rename the function to tx_to_dictionary_as_inner_for_relayed_v1. Or perhaps can we use the builder from core instead? Can be in a next PR.
There was a problem hiding this comment.
Renamed to tx_to_dictionary_as_inner_for_relayed_v1. Was thinking about using the builder, but since here we simply format the data field of the relayed transaction it's not suitable. We also marked the builders as deprecated, will probably use the factory, when it's ready.
pyproject.toml
Outdated
| "multiversx-sdk-network-providers>=0.11.0,<0.12.0", | ||
| "multiversx-sdk-wallet>=0.8.0,<0.9.0", | ||
| "multiversx-sdk-core>=0.6.0,<0.7.0" | ||
| "multiversx-sdk-network-providers==0.12.0", |
| testdata_path = Path(__file__).parent / "testdata" | ||
|
|
||
|
|
||
| def test_relayed_v1_transaction(capsys: Any): |
| "--data", "getContractConfig", | ||
| "--version", "1", | ||
| "--chain", "T", | ||
| "--relay" |
There was a problem hiding this comment.
In the future, we should add support for relayed V2, as well.
Integrated the latest versions of
sdk-core,sdk-walletandsdk-network-providersinto mxpy.