`./mptcp_connect.sh -m mmap` test blocks #160

matttbe · 2021-02-12T13:31:32Z

My CI reported a timeout today with mptcp_connect.sh -m mmap:

01:22:44.570 # INFO: set ns4-6026271e-J37dIg dev ns4eth3: ethtool -K tso off gso off
01:22:44.620 # Created /tmp/tmp.utnxTI2AGP (size 4661276	/tmp/tmp.utnxTI2AGP) containing data sent by client
01:22:44.678 # Created /tmp/tmp.DUoIEnRAN0 (size 5651484	/tmp/tmp.DUoIEnRAN0) containing data sent by server
01:22:44.737 # New MPTCP socket can be blocked via sysctl		[ OK ]
01:22:44.811 # setsockopt(..., TCP_ULP, "mptcp", ...) blocked	[ OK ]
01:22:44.846 # INFO: validating network environment with pings
01:22:44.861 # INFO: Using loss of 0.09% delay 11 ms reorder 96% 88% with delay 2ms on ns3eth4
01:22:47.928 # INFO: extra options:  -m mmap
01:22:47.939 # ns1 MPTCP -> ns1 (10.0.1.1:10000      ) MPTCP	(duration   323ms) [ OK ]
01:22:48.501 # ns1 MPTCP -> ns1 (10.0.1.1:10001      ) TCP  	(duration   150ms) [ OK ]
01:22:48.890 # ns1 TCP   -> ns1 (10.0.1.1:10002      ) MPTCP	(duration    32ms) [ OK ]
01:22:49.168 # ns1 MPTCP -> ns1 (dead:beef:1::1:10003) MPTCP	(duration   178ms) [ OK ]
01:22:49.588 # ns1 MPTCP -> ns1 (dead:beef:1::1:10004) TCP  	(duration    95ms) [ OK ]
01:22:49.939 # ns1 TCP   -> ns1 (dead:beef:1::1:10005) MPTCP	(duration    29ms) [ OK ]
01:22:50.215 # ns1 MPTCP -> ns2 (10.0.1.2:10006      ) MPTCP	(duration   807ms) [ OK ]
01:22:51.283 # ns1 MPTCP -> ns2 (dead:beef:1::2:10007) MPTCP	(duration   881ms) [ OK ]
01:22:52.425 # ns1 MPTCP -> ns2 (10.0.2.1:10008      ) MPTCP	(duration   915ms) [ OK ]
01:22:53.610 # ns1 MPTCP -> ns2 (dead:beef:2::1:10009) MPTCP	(duration   970ms) [ OK ]
01:22:54.842 # ns1 MPTCP -> ns3 (10.0.2.2:10010      ) MPTCP	(duration   275ms) [ OK ]
01:22:55.376 # ns1 MPTCP -> ns3 (dead:beef:2::2:10011) MPTCP	(duration   263ms) [ OK ]
01:22:55.905 # ns1 MPTCP -> ns3 (10.0.3.2:10012      ) MPTCP	(duration   265ms) [ OK ]
01:22:56.440 # ns1 MPTCP -> ns3 (dead:beef:3::2:10013) MPTCP	(duration   261ms) [ OK ]
01:22:56.970 # ns1 MPTCP -> ns4 (10.0.3.1:10014      ) MPTCP	(duration   324ms) [ OK ]
01:22:57.562 # ns1 MPTCP -> ns4 (dead:beef:3::1:10015) MPTCP	(duration   250ms) [ OK ]
01:22:58.077 Timeout: sending Ctrl+C
01:39:38.078 # ns2 MPTCP -> ns1 (10.0.1.1:10016      ) MPTCP	^C/usr/lib/klibc/bin/poweroff

I tried to reproduce with my CI but I was not able to. It was without a debug kernel.

The text was updated successfully, but these errors were encountered:

matttbe · 2021-02-18T15:46:33Z

Note: as suggested by @pabeni I tried to use SO_SNDTIMEO but I still have timeouts:

diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c
index 77bb62feb872..c785e6a9712f 100644
--- a/tools/testing/selftests/net/mptcp/mptcp_connect.c
+++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c
@@ -36,6 +36,7 @@ extern int optind;
 #endif
 
 static int  poll_timeout = 10 * 1000;
+static int  send_timeout = 10;
 static bool listen_mode;
 static bool quit;
 
@@ -139,6 +140,18 @@ static void set_sndbuf(int fd, unsigned int size)
        }
 }
 
+static void set_snd_timeout(int fd, int timeo_sec)
+{
+       struct timeval timeo = { .tv_sec = timeo_sec };
+       int err;
+
+       err = setsockopt(fd, SOL_SOCKET, SO_SNDTIMEO, &timeo, sizeof(timeo));
+       if (err) {
+               perror("set SO_SNDTIMEO");
+               exit(1);
+       }
+}
+
 static int sock_listen_mptcp(const char * const listenaddr,
                             const char * const port)
 {
@@ -723,6 +736,8 @@ int main_loop_s(int listensock)
                maybe_close(listensock);
                check_sockaddr(pf, &ss, salen);
                check_getpeername(remotesock, &ss, salen);
+               if (send_timeout)
+                       set_snd_timeout(remotesock, send_timeout);
 
                return copyfd_io(0, remotesock, 1);
        }
@@ -763,6 +776,8 @@ int main_loop(void)
                set_rcvbuf(fd, cfg_rcvbuf);
        if (cfg_sndbuf)
                set_sndbuf(fd, cfg_sndbuf);
+       if (send_timeout)
+               set_snd_timeout(fd, send_timeout);
 
        return copyfd_io(0, fd, 1);
 }
@@ -860,7 +875,8 @@ static void parse_opts(int argc, char **argv)
                        pf = AF_INET6;
                        break;
                case 't':
-                       poll_timeout = atoi(optarg) * 1000;
+                       send_timeout = atoi(optarg);
+                       poll_timeout = send_timeout * 1000;
                        if (poll_timeout <= 0)
                                poll_timeout = -1;
                        break;
@@ -907,6 +923,8 @@ int main(int argc, char *argv[])
                        set_rcvbuf(fd, cfg_rcvbuf);
                if (cfg_sndbuf)
                        set_sndbuf(fd, cfg_sndbuf);
+               if (send_timeout > 0)
+                       set_snd_timeout(fd, send_timeout);
 
                return main_loop_s(fd);
        }

EDIT: now with SO_SNDTIMEO on the fd received from the accept()

pabeni · 2021-02-18T18:37:53Z

I managed to reproduce it locally (after 120 iterations :(((():

Created /tmp/tmp.9IJFiotmJt (size 6675484	/tmp/tmp.9IJFiotmJt) containing data sent by client
Created /tmp/tmp.9Lnlt5aMvd (size 3133468	/tmp/tmp.9Lnlt5aMvd) containing data sent by server
[...]
INFO: Using loss of 0.63% delay 8 ms reorder 94% 85% with delay 2ms on ns3eth4
[... hangs ns2 MPTCP -> ns3 ipv6]

Dumping the sk status:

ip netns exec ns2-602eace1-io3JRe ss -tMnimO
Netid         State              Recv-Q         Send-Q                    Local Address:Port                      Peer Address:Port          Process                                                                                                                                      
tcp           ESTAB              0              0                      [dead:beef:2::1]:45442                 [dead:beef:2::2]:10019          skmem:(r0,rb540000,t0,tb4194304,f0,w0,o0,bl0,d0) cubic wscale:8,8 rto:209 rtt:8.461/0.204 mss:1428 pmtu:1500 rcvmss:536 advmss:1428 cwnd:1328 ssthresh:1147 bytes_sent:6675484 bytes_acked:6675485 segs_out:4761 segs_in:140 data_segs_out:4758 send 1793058976bps lastsnd:821972 lastrcv:822057 lastack:821963 pacing_rate 2151543624bps delivery_rate 1541174088bps delivered:4759 busy:91ms rcv_space:14280 rcv_ssthresh:65535 minrtt:8.152 tcp-ulp-mptcp flags:Mmec token:0000(id:0)/6a09c259(id:0) seq:b407e5c7ce9b07c sfseq:1 ssnoff:5915f98c maplen:0
mptcp         FIN-WAIT-1         0              0                      [dead:beef:2::1]:45442                 [dead:beef:2::2]:10019          skmem:(r0,rb540000,t0,tb4194304,f1125120,w0,o0,bl0,d0) remote_key token:6a09c259 write_seq:f13e5429a324900e snd_una:f13e5429a324900d rcv_nxt:b407e5c7ce9b07c
ip netns exec ns3-602eace1-io3JRe ss -tMnimO
Netid         State         Recv-Q          Send-Q                      Local Address:Port                        Peer Address:Port          Process                                                                                                                                      
tcp           ESTAB         0               0                        [dead:beef:2::2]:10019                   [dead:beef:2::1]:45442          skmem:(r0,rb9606324,t0,tb262144,f135168,w0,o0,bl0,d0) cubic wscale:8,8 rto:209 rtt:8.373/4.186 ato:40 mss:1428 pmtu:1500 rcvmss:1404 advmss:1428 cwnd:10 bytes_received:6675484 segs_out:139 segs_in:4760 data_segs_in:4758 send 13643855bps lastsnd:817224 lastrcv:817138 lastack:817138 pacing_rate 27287704bps delivered:1 rcv_rtt:9.01 rcv_space:14400 rcv_ssthresh:4792694 minrtt:8.373 tcp-ulp-mptcp flags:Mec token:0000(id:0)/9a113fc5(id:0) seq:f13e5429a323dead sfseq:652abd ssnoff:f1d162 maplen:b160
mptcp         ESTAB         0               0                        [dead:beef:2::2]:10019                   [dead:beef:2::1]:45442          skmem:(r0,rb9606324,t0,tb262144,f1708032,w0,o0,bl0,d0) remote_key token:9a113fc5 write_seq:b407e5c7ce9b07c snd_una:b407e5c7ce9b07c rcv_nxt:f13e5429a324900d

The test is lossy, and one side completely spooled the data, and is waiting for DATA_FIN ack (mptcp status is FIN-WAIT-1). Looks like DATA_FIN or DATA FIN ack has been lost, and never re-transmitted. That is possible since we never retranmit data_fin//data_fin ack and the mmap transfer is monodirectional (first all data are dumped one-way, the the opposite one). Being the transfer monodirectional, we lost the opportunity to "accidentally" retransmit data_fin /data_fin ack with some data packet.

The above can happen even in poll test, when the client/server files have very different sizes - it's just even more rare due to the additional constraint.

So overall this looks a dup of: issue #146

We can increase the confidence with the above running mmap only lossy test, with high loss probability on small files, so that dropping data fin should be quite probable and the test itself should still be quite fast. All the above capturing the pcap dump

matttbe · 2021-02-23T15:29:29Z

@pabeni: thank you for the analysis!

Indeed, it looks like it is easier to reproduce with ./mptcp_connect.sh -m mmap -f 1 -l 2
(or a packetdrill)

I guess it is not linked to #137 where we have sockets in TIME-WAIT, not FIN-WAIT-1.

'mptcp_connect' already has a timeout for poll() but in some cases, it is not enough. With "timeout" tool, we will force the command to fail if it doesn't finish on time. Thanks to that, the script will continue and display details about the current state before marking the test as failed. Displaying this state is very important to be able to understand the issue. Best to have our CI reporting the issue than just "the test hanged". Note that in mptcp_connect.sh, we were using a long timeout to validate the fact we cannot create a socket if a sysctl is set. We don't need this timeout. Closes: #160 Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Matthieu Baerts <[email protected]>

'mptcp_connect' already has a timeout for poll() but in some cases, it is not enough. With "timeout" tool, we will force the command to fail if it doesn't finish on time. Thanks to that, the script will continue and display details about the current state before marking the test as failed. Displaying this state is very important to be able to understand the issue. Best to have our CI reporting the issue than just "the test hanged". Note that in mptcp_connect.sh, we were using a long timeout to validate the fact we cannot create a socket if a sysctl is set. We don't need this timeout. Closes: multipath-tcp#160 Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Matthieu Baerts <[email protected]>

'mptcp_connect' already has a timeout for poll() but in some cases, it is not enough. With "timeout" tool, we will force the command to fail if it doesn't finish on time. Thanks to that, the script will continue and display details about the current state before marking the test as failed. Displaying this state is very important to be able to understand the issue. Best to have our CI reporting the issue than just "the test hanged". Note that in mptcp_connect.sh, we were using a long timeout to validate the fact we cannot create a socket if a sysctl is set. We don't need this timeout. Closes: #160 Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Matthieu Baerts <[email protected]>

'mptcp_connect' already has a timeout for poll() but in some cases, it is not enough. With "timeout" tool, we will force the command to fail if it doesn't finish on time. Thanks to that, the script will continue and display details about the current state before marking the test as failed. Displaying this state is very important to be able to understand the issue. Best to have our CI reporting the issue than just "the test hanged". Note that in mptcp_connect.sh, we were using a long timeout to validate the fact we cannot create a socket if a sysctl is set. We don't need this timeout. In diag.sh, we want to send signals to mptcp_connect instances that have been started in the netns. But we cannot send this signal to 'timeout' otherwise that will stop the timeout and messages telling us SIGUSR1 has been received will be printed. Instead of trying to find the right PID and storing them in an array, we can simply use the output of 'ip netns pids' which is all the PIDs we want to send signal to. Closes: #160 Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Matthieu Baerts <[email protected]>

'mptcp_connect' already has a timeout for poll() but in some cases, it is not enough. With "timeout" tool, we will force the command to fail if it doesn't finish on time. Thanks to that, the script will continue and display details about the current state before marking the test as failed. Displaying this state is very important to be able to understand the issue. Best to have our CI reporting the issue than just "the test hanged". Note that in mptcp_connect.sh, we were using a long timeout to validate the fact we cannot create a socket if a sysctl is set. We don't need this timeout. In diag.sh, we want to send signals to mptcp_connect instances that have been started in the netns. But we cannot send this signal to 'timeout' otherwise that will stop the timeout and messages telling us SIGUSR1 has been received will be printed. Instead of trying to find the right PID and storing them in an array, we can simply use the output of 'ip netns pids' which is all the PIDs we want to send signal to. Closes: multipath-tcp/mptcp_net-next#160 Signed-off-by: Matthieu Baerts <[email protected]> Signed-off-by: Mat Martineau <[email protected]> Signed-off-by: David S. Miller <[email protected]>

Fix BPF_CORE_READ_BITFIELD() macro used for reading CO-RE-relocatable bitfields. Missing breaks in a switch caused 8-byte reads always. This can confuse libbpf because it does strict checks that memory load size corresponds to the original size of the field, which in this case quite often would be wrong. After fixing that, we run into another problem, which quite subtle, so worth documenting here. The issue is in Clang optimization and CO-RE relocation interactions. Without that asm volatile construct (also known as barrier_var()), Clang will re-order BYTE_OFFSET and BYTE_SIZE relocations and will apply BYTE_OFFSET 4 times for each switch case arm. This will result in the same error from libbpf about mismatch of memory load size and original field size. I.e., if we were reading u32, we'd still have *(u8 *), *(u16 *), *(u32 *), and *(u64 *) memory loads, three of which will fail. Using barrier_var() forces Clang to apply BYTE_OFFSET relocation first (and once) to calculate p, after which value of p is used without relocation in each of switch case arms, doing appropiately-sized memory load. Here's the list of relevant relocations and pieces of generated BPF code before and after this patch for test_core_reloc_bitfields_direct selftests. BEFORE ===== #45: core_reloc: insn #160 --> [5] + 0:5: byte_sz --> struct core_reloc_bitfields.u32 #46: core_reloc: insn #167 --> [5] + 0:5: byte_off --> struct core_reloc_bitfields.u32 #47: core_reloc: insn #174 --> [5] + 0:5: byte_off --> struct core_reloc_bitfields.u32 #48: core_reloc: insn #178 --> [5] + 0:5: byte_off --> struct core_reloc_bitfields.u32 #49: core_reloc: insn #182 --> [5] + 0:5: byte_off --> struct core_reloc_bitfields.u32 157: 18 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 r2 = 0 ll 159: 7b 12 20 01 00 00 00 00 *(u64 *)(r2 + 288) = r1 160: b7 02 00 00 04 00 00 00 r2 = 4 ; BYTE_SIZE relocation here ^^^ 161: 66 02 07 00 03 00 00 00 if w2 s> 3 goto +7 <LBB0_63> 162: 16 02 0d 00 01 00 00 00 if w2 == 1 goto +13 <LBB0_65> 163: 16 02 01 00 02 00 00 00 if w2 == 2 goto +1 <LBB0_66> 164: 05 00 12 00 00 00 00 00 goto +18 <LBB0_69> 0000000000000528 <LBB0_66>: 165: 18 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 r1 = 0 ll 167: 69 11 08 00 00 00 00 00 r1 = *(u16 *)(r1 + 8) ; BYTE_OFFSET relo here w/ WRONG size ^^^^^^^^^^^^^^^^ 168: 05 00 0e 00 00 00 00 00 goto +14 <LBB0_69> 0000000000000548 <LBB0_63>: 169: 16 02 0a 00 04 00 00 00 if w2 == 4 goto +10 <LBB0_67> 170: 16 02 01 00 08 00 00 00 if w2 == 8 goto +1 <LBB0_68> 171: 05 00 0b 00 00 00 00 00 goto +11 <LBB0_69> 0000000000000560 <LBB0_68>: 172: 18 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 r1 = 0 ll 174: 79 11 08 00 00 00 00 00 r1 = *(u64 *)(r1 + 8) ; BYTE_OFFSET relo here w/ WRONG size ^^^^^^^^^^^^^^^^ 175: 05 00 07 00 00 00 00 00 goto +7 <LBB0_69> 0000000000000580 <LBB0_65>: 176: 18 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 r1 = 0 ll 178: 71 11 08 00 00 00 00 00 r1 = *(u8 *)(r1 + 8) ; BYTE_OFFSET relo here w/ WRONG size ^^^^^^^^^^^^^^^^ 179: 05 00 03 00 00 00 00 00 goto +3 <LBB0_69> 00000000000005a0 <LBB0_67>: 180: 18 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 r1 = 0 ll 182: 61 11 08 00 00 00 00 00 r1 = *(u32 *)(r1 + 8) ; BYTE_OFFSET relo here w/ RIGHT size ^^^^^^^^^^^^^^^^ 00000000000005b8 <LBB0_69>: 183: 67 01 00 00 20 00 00 00 r1 <<= 32 184: b7 02 00 00 00 00 00 00 r2 = 0 185: 16 02 02 00 00 00 00 00 if w2 == 0 goto +2 <LBB0_71> 186: c7 01 00 00 20 00 00 00 r1 s>>= 32 187: 05 00 01 00 00 00 00 00 goto +1 <LBB0_72> 00000000000005e0 <LBB0_71>: 188: 77 01 00 00 20 00 00 00 r1 >>= 32 AFTER ===== #30: core_reloc: insn #132 --> [5] + 0:5: byte_off --> struct core_reloc_bitfields.u32 #31: core_reloc: insn #134 --> [5] + 0:5: byte_sz --> struct core_reloc_bitfields.u32 129: 18 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 r2 = 0 ll 131: 7b 12 20 01 00 00 00 00 *(u64 *)(r2 + 288) = r1 132: b7 01 00 00 08 00 00 00 r1 = 8 ; BYTE_OFFSET relo here ^^^ ; no size check for non-memory dereferencing instructions 133: 0f 12 00 00 00 00 00 00 r2 += r1 134: b7 03 00 00 04 00 00 00 r3 = 4 ; BYTE_SIZE relocation here ^^^ 135: 66 03 05 00 03 00 00 00 if w3 s> 3 goto +5 <LBB0_63> 136: 16 03 09 00 01 00 00 00 if w3 == 1 goto +9 <LBB0_65> 137: 16 03 01 00 02 00 00 00 if w3 == 2 goto +1 <LBB0_66> 138: 05 00 0a 00 00 00 00 00 goto +10 <LBB0_69> 0000000000000458 <LBB0_66>: 139: 69 21 00 00 00 00 00 00 r1 = *(u16 *)(r2 + 0) ; NO CO-RE relocation here ^^^^^^^^^^^^^^^^ 140: 05 00 08 00 00 00 00 00 goto +8 <LBB0_69> 0000000000000468 <LBB0_63>: 141: 16 03 06 00 04 00 00 00 if w3 == 4 goto +6 <LBB0_67> 142: 16 03 01 00 08 00 00 00 if w3 == 8 goto +1 <LBB0_68> 143: 05 00 05 00 00 00 00 00 goto +5 <LBB0_69> 0000000000000480 <LBB0_68>: 144: 79 21 00 00 00 00 00 00 r1 = *(u64 *)(r2 + 0) ; NO CO-RE relocation here ^^^^^^^^^^^^^^^^ 145: 05 00 03 00 00 00 00 00 goto +3 <LBB0_69> 0000000000000490 <LBB0_65>: 146: 71 21 00 00 00 00 00 00 r1 = *(u8 *)(r2 + 0) ; NO CO-RE relocation here ^^^^^^^^^^^^^^^^ 147: 05 00 01 00 00 00 00 00 goto +1 <LBB0_69> 00000000000004a0 <LBB0_67>: 148: 61 21 00 00 00 00 00 00 r1 = *(u32 *)(r2 + 0) ; NO CO-RE relocation here ^^^^^^^^^^^^^^^^ 00000000000004a8 <LBB0_69>: 149: 67 01 00 00 20 00 00 00 r1 <<= 32 150: b7 02 00 00 00 00 00 00 r2 = 0 151: 16 02 02 00 00 00 00 00 if w2 == 0 goto +2 <LBB0_71> 152: c7 01 00 00 20 00 00 00 r1 s>>= 32 153: 05 00 01 00 00 00 00 00 goto +1 <LBB0_72> 00000000000004d0 <LBB0_71>: 154: 77 01 00 00 20 00 00 00 r1 >>= 323 Fixes: ee26dad ("libbpf: Add support for relocatable bitfields") Signed-off-by: Andrii Nakryiko <[email protected]> Signed-off-by: Alexei Starovoitov <[email protected]> Acked-by: Lorenz Bauer <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]

[ Upstream commit 5888a61 ] 'mptcp_connect' already has a timeout for poll() but in some cases, it is not enough. With "timeout" tool, we will force the command to fail if it doesn't finish on time. Thanks to that, the script will continue and display details about the current state before marking the test as failed. Displaying this state is very important to be able to understand the issue. Best to have our CI reporting the issue than just "the test hanged". Note that in mptcp_connect.sh, we were using a long timeout to validate the fact we cannot create a socket if a sysctl is set. We don't need this timeout. In diag.sh, we want to send signals to mptcp_connect instances that have been started in the netns. But we cannot send this signal to 'timeout' otherwise that will stop the timeout and messages telling us SIGUSR1 has been received will be printed. Instead of trying to find the right PID and storing them in an array, we can simply use the output of 'ip netns pids' which is all the PIDs we want to send signal to. Closes: multipath-tcp/mptcp_net-next#160 Signed-off-by: Matthieu Baerts <[email protected]> Signed-off-by: Mat Martineau <[email protected]> Signed-off-by: David S. Miller <[email protected]> Signed-off-by: Sasha Levin <[email protected]>

Move am65_cpsw_nuss_phylink_cleanup() call to after am65_cpsw_nuss_cleanup_ndev() so phylink is still valid to prevent the below Segmentation fault on module remove when first slave link is up. [ 31.652944] Unable to handle kernel paging request at virtual address 00040008000005f4 [ 31.684627] Mem abort info: [ 31.687446] ESR = 0x0000000096000004 [ 31.704614] EC = 0x25: DABT (current EL), IL = 32 bits [ 31.720663] SET = 0, FnV = 0 [ 31.723729] EA = 0, S1PTW = 0 [ 31.740617] FSC = 0x04: level 0 translation fault [ 31.756624] Data abort info: [ 31.759508] ISV = 0, ISS = 0x00000004 [ 31.776705] CM = 0, WnR = 0 [ 31.779695] [00040008000005f4] address between user and kernel address ranges [ 31.808644] Internal error: Oops: 0000000096000004 [#1] PREEMPT SMP [ 31.814928] Modules linked in: wlcore_sdio wl18xx wlcore mac80211 libarc4 cfg80211 rfkill crct10dif_ce phy_gmii_sel ti_am65_cpsw_nuss(-) sch_fq_codel ipv6 [ 31.828776] CPU: 0 PID: 1026 Comm: modprobe Not tainted 6.1.0-rc2-00012-gfabfcf7dafdb-dirty #160 [ 31.837547] Hardware name: Texas Instruments AM625 (DT) [ 31.842760] pstate: 40000005 (nZcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 31.849709] pc : phy_stop+0x18/0xf8 [ 31.853202] lr : phylink_stop+0x38/0xf8 [ 31.857031] sp : ffff80000a0839f0 [ 31.860335] x29: ffff80000a0839f0 x28: ffff000000de1c80 x27: 0000000000000000 [ 31.867462] x26: 0000000000000000 x25: 0000000000000000 x24: ffff80000a083b98 [ 31.874589] x23: 0000000000000800 x22: 0000000000000001 x21: ffff000001bfba90 [ 31.881715] x20: ffff0000015ee000 x19: 0004000800000200 x18: 0000000000000000 [ 31.888842] x17: ffff800076c45000 x16: ffff800008004000 x15: 000058e39660b106 [ 31.895969] x14: 0000000000000144 x13: 0000000000000144 x12: 0000000000000000 [ 31.903095] x11: 000000000000275f x10: 00000000000009e0 x9 : ffff80000a0837d0 [ 31.910222] x8 : ffff000000de26c0 x7 : ffff00007fbd6540 x6 : ffff00007fbd64c0 [ 31.917349] x5 : ffff00007fbd0b10 x4 : ffff00007fbd0b10 x3 : ffff00007fbd3920 [ 31.924476] x2 : d0a07fcff8b8d500 x1 : 0000000000000000 x0 : 0004000800000200 [ 31.931603] Call trace: [ 31.934042] phy_stop+0x18/0xf8 [ 31.937177] phylink_stop+0x38/0xf8 [ 31.940657] am65_cpsw_nuss_ndo_slave_stop+0x28/0x1e0 [ti_am65_cpsw_nuss] [ 31.947452] __dev_close_many+0xa4/0x140 [ 31.951371] dev_close_many+0x84/0x128 [ 31.955115] unregister_netdevice_many+0x130/0x6d0 [ 31.959897] unregister_netdevice_queue+0x94/0xd8 [ 31.964591] unregister_netdev+0x24/0x38 [ 31.968504] am65_cpsw_nuss_cleanup_ndev.isra.0+0x48/0x70 [ti_am65_cpsw_nuss] [ 31.975637] am65_cpsw_nuss_remove+0x58/0xf8 [ti_am65_cpsw_nuss] Cc: <[email protected]> # v5.18+ Fixes: e8609e6 ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK") Signed-off-by: Roger Quadros <[email protected]> Signed-off-by: David S. Miller <[email protected]>

Add a new selftest to check the PTR_UNTRUSTED condition. Below is the result, #160 ptr_untrusted:OK Signed-off-by: Yafang Shao <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexei Starovoitov <[email protected]>

matttbe added the bug label Feb 12, 2021

matttbe self-assigned this Feb 18, 2021

jenkins-tessares closed this as completed in 6a7d555 Feb 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`./mptcp_connect.sh -m mmap` test blocks #160

`./mptcp_connect.sh -m mmap` test blocks #160

matttbe commented Feb 12, 2021

matttbe commented Feb 18, 2021 •

edited

Loading

pabeni commented Feb 18, 2021 •

edited

Loading

matttbe commented Feb 23, 2021

./mptcp_connect.sh -m mmap test blocks #160

./mptcp_connect.sh -m mmap test blocks #160

Comments

matttbe commented Feb 12, 2021

matttbe commented Feb 18, 2021 • edited Loading

pabeni commented Feb 18, 2021 • edited Loading

matttbe commented Feb 23, 2021

`./mptcp_connect.sh -m mmap` test blocks #160

`./mptcp_connect.sh -m mmap` test blocks #160

matttbe commented Feb 18, 2021 •

edited

Loading

pabeni commented Feb 18, 2021 •

edited

Loading