mptcp: reset last_snd on subflow close

Send logic caches last active subflow in the msk, so it needs to be cleared when the cached subflow is closed. Fixes: d5f4919 ("mptcp: allow picking different xmit subflows") Closes: #155 Reported-by: Christoph Paasch <[email protected]> Acked-by: Paolo Abeni <[email protected]> Reviewed-by: Matthieu Baerts <[email protected]> Signed-off-by: Florian Westphal <[email protected]>
multipath-tcp · Feb 18, 2021 · c1e8864 · c1e8864
1 parent 38b5133
commit c1e8864
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
@@ -2124,6 +2124,8 @@ static struct sock *mptcp_subflow_get_retrans(const struct mptcp_sock *msk)
 static void __mptcp_close_ssk(struct sock *sk, struct sock *ssk,
 			      struct mptcp_subflow_context *subflow)
 {
+	struct mptcp_sock *msk = mptcp_sk(sk);
+
 	list_del(&subflow->node);
 
 	lock_sock_nested(ssk, SINGLE_DEPTH_NESTING);
@@ -2152,6 +2154,9 @@ static void __mptcp_close_ssk(struct sock *sk, struct sock *ssk,
 	release_sock(ssk);
 
 	sock_put(ssk);
+
+	if (ssk == msk->last_snd)
+		msk->last_snd = NULL;
 }
 
 void mptcp_close_ssk(struct sock *sk, struct sock *ssk,