Skip to content

Commit

Permalink
selftests: mptcp: join: validate fullmesh endp on 1st sf
Browse files Browse the repository at this point in the history
This case was not covered, and the wrong ID was set before the previous
commit.

The rest is not modified, it is just that it will increase the code
coverage.

The right address ID can be verified by looking at the packet traces. We
could automate that using Netfilter with some cBPF code for example, but
that's always a bit cryptic. Packetdrill seems better fitted for that.

Fixes: 4f49d63 ("selftests: mptcp: add fullmesh testcases")
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Message-Id: <[email protected]>
  • Loading branch information
matttbe authored and Patchew Applier committed Jul 19, 2024
1 parent 14bf658 commit 91587d8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/testing/selftests/net/mptcp/mptcp_join.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3014,6 +3014,7 @@ fullmesh_tests()
if reset "fullmesh test 1x1"; then
pm_nl_set_limits $ns1 1 3
pm_nl_set_limits $ns2 1 3
pm_nl_add_endpoint $ns2 10.0.1.2 flags subflow,fullmesh
pm_nl_add_endpoint $ns1 10.0.2.1 flags signal
fullmesh=1 speed=slow \
run_tests $ns1 $ns2 10.0.1.1
Expand Down

0 comments on commit 91587d8

Please sign in to comment.