Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove per-hash digest type #156

Merged
merged 1 commit into from
Jan 27, 2022
Merged

remove per-hash digest type #156

merged 1 commit into from
Jan 27, 2022

Commits on Jan 27, 2022

  1. remove per-hash digest type

    Remove the per-hasher digest type. Instead, store hash digests inside
    the hashers and "borrow" it. In all cases, we're going to copy it into a
    `Multihash<S>` anyways.
    
    This:
    
    1. Removes bunch of code.
    2. Means that hashers don't need to be generic over the size (unless
    they actually support multiple sizes). This fixes the UX issue
    introduced in the const generics PR.
    3. Avoids some copying.
    
    BREAKING CHANGE
    
    1. `Hasher.digest` no longer exists. Users should use
    `Code::SomeCode.digest` where possible.
    2. The hasher digests no longer exist.
    Stebalien authored and vmx committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    897509d View commit details
    Browse the repository at this point in the history