update crate to edition 2021 #72
Conversation
- update multihash to v0.18.0 - update quickcheck to v1.0.3
|
@mxinden PTAL |
| @@ -1,7 +1,8 @@ | |||
| [package] | |||
| authors = ["dignifiedquire <[email protected]>", "Parity Technologies <[email protected]>"] | |||
| description = "Implementation of the multiaddr format" | |||
| edition = "2018" | |||
| edition = "2021" | |||
| rust-version = "1.59.0" | |||
There was a problem hiding this comment.
Curious, why 1.59.0? The first version that supports the field is 1.56.0
There was a problem hiding this comment.
because the MSRV of multihash-v0.18 is 1.59.0
There was a problem hiding this comment.
Does ones MSRV need to be >= to ones dependencie's MSRV?
| @@ -17,7 +18,7 @@ arrayref = "0.3" | |||
| byteorder = "1.3.1" | |||
| data-encoding = "2.1" | |||
| multibase = "0.9.1" | |||
| multihash = { version = "0.17", default-features = false, features = ["std", "multihash-impl", "identity"] } | |||
| multihash = { version = "0.18", default-features = false, features = ["std", "multihash-impl", "identity"] } | |||
There was a problem hiding this comment.
This will be another breaking change across the entire Rust libp2p ecosystem. Unless this upgrade is a blocker for something, it would be nice if we could hold off releasing this until multiformats/rust-multihash#259 is actioned.
There was a problem hiding this comment.
We should be able to upgrade to edition 2021 without having to bump this, right?
There was a problem hiding this comment.
#73 is also a breaking change, can we include that as-well? I don't have permissions to create a milestone in this repository but it might be worthwhile creating one so we can plan these things :)
| @@ -17,7 +18,7 @@ arrayref = "0.3" | |||
| byteorder = "1.3.1" | |||
| data-encoding = "2.1" | |||
| multibase = "0.9.1" | |||
| multihash = { version = "0.17", default-features = false, features = ["std", "multihash-impl", "identity"] } | |||
| multihash = { version = "0.18", default-features = false, features = ["std", "multihash-impl", "identity"] } | |||
| fn arbitrary<G: Gen>(g: &mut G) -> Self { | ||
| let iter = (0..g.next_u32() % 128).map(|_| Proto::arbitrary(g).0); | ||
| fn arbitrary(g: &mut Gen) -> Self { | ||
| let iter = (0..u8::arbitrary(g) % 128).map(|_| Proto::arbitrary(g).0); |
There was a problem hiding this comment.
😮 change needed is a lot smaller than anticipated. Thanks.
| @@ -1,7 +1,8 @@ | |||
| [package] | |||
| authors = ["dignifiedquire <[email protected]>", "Parity Technologies <[email protected]>"] | |||
| description = "Implementation of the multiaddr format" | |||
| edition = "2018" | |||
| edition = "2021" | |||
| rust-version = "1.59.0" | |||
There was a problem hiding this comment.
Does ones MSRV need to be >= to ones dependencie's MSRV?
yes |
multihashto v0.18.0quickcheckto v1.0.3close #41
close #49