You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the feature definitions are not ideal. E.g. does the std feature define serde/std which leads to serde being a dependency, even if the serde-codec feature is not enabled. The same is true for other dependencies. As features are additive, it actually shouldn't be needed to explicitly set serde/std and the std feature would enable it anyway.
Besides that it would make sense to clean the whole things up and make use of the dep: and '?` syntax. We are already on a minimum supported Rust version of 1.60, so we can use that syntax.
For example the `std` feature was pulling in `serde` even when it was
not enabled by any features.
This commit also renames the `serde-codec` feature to just `serde` to
be aligned with rust-multihash.
Fixes#142.
For example the `std` feature was pulling in `serde` even when it was
not enabled by any features.
This commit also renames the `serde-codec` feature to just `serde` to
be aligned with rust-multihash.
Fixes#142.
For example the `std` feature was pulling in `serde` even when it was
not enabled by any features.
This commit also renames the `serde-codec` feature to just `serde` to
be aligned with rust-multihash.
Fixes#142.
Currently the feature definitions are not ideal. E.g. does the
std
feature defineserde/std
which leads toserde
being a dependency, even if theserde-codec
feature is not enabled. The same is true for other dependencies. As features are additive, it actually shouldn't be needed to explicitly setserde/std
and thestd
feature would enable it anyway.Besides that it would make sense to clean the whole things up and make use of the
dep:
and '?` syntax. We are already on a minimum supported Rust version of 1.60, so we can use that syntax.The
serde-codec
feature could then also be renamed to justserde
, following rust-multihash: https://github.com/multiformats/rust-multihash/blob/452a933396adcd5915c53563d5017df76ae3ec26/Cargo.toml#L24-L25The text was updated successfully, but these errors were encountered: