Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a multicodec to identify Ethereum Solidity ABI-encoded data #363

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a multicodec to identify Ethereum Solidity ABI-encoded data #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions table.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ eth-account-snapshot, ipld, 0x97, permanent, Ethe
eth-storage-trie, ipld, 0x98, permanent, Ethereum Contract Storage Trie (Eth-Secure-Trie)
eth-receipt-log-trie, ipld, 0x99, draft, Ethereum Transaction Receipt Log Trie (Eth-Trie)
eth-receipt-log, ipld, 0x9a, draft, Ethereum Transaction Receipt Log (RLP)
eth-solidity-abi, ipld, 0x9b, draft, Ethereum Solidity ABI-encoded data
Copy link

@bumblefudge bumblefudge Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something more concrete for the description might help, since it's currently just redundant to the name:

Suggested change
eth-solidity-abi, ipld, 0x9b, draft, Ethereum Solidity ABI-encoded data
eth-solidity-abi, ipld, 0x9b, draft, ABI-encoded contract calls from EVM environments

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not just "calls", returns can also be encoded in this form too

Copy link
Member Author

@raulk raulk Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of this is correct.
(a) as mentioned above, Solidity ABI encoding is used for more than just calls.
(b) the EVM does not care about the ABI.
(c) it is Ethereum-related, so let's keep Ethereum in the description.

aes-128, key, 0xa0, draft, 128-bit AES symmetric key
aes-192, key, 0xa1, draft, 192-bit AES symmetric key
aes-256, key, 0xa2, draft, 256-bit AES symmetric key
Expand Down
Loading