Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Add lead-maintainer #51

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Add lead-maintainer #51

merged 1 commit into from
Apr 30, 2018

Conversation

daviddias
Copy link
Member

@daviddias
Copy link
Member Author

This is the first PR towards the goal of ipfs/community#301 (comment)

I've updated the permissions of this repo to

image

I believe these restrictions to be sane, but would like someone to double check.

@victorb
Copy link
Member

victorb commented Apr 30, 2018

The "require status checks to pass before merging" option needs to have a status check that is marked as required, otherwise this option does nothing. Should probably be the continuous-integration/jenkins/pr-merge status check as that one includes the full jenkins build on merge.

I think "Restrict who can push to this branch" should be activated and no one should be allowed to push directly to master. From the screenshot, you'll be able to push but no one else.

@daviddias
Copy link
Member Author

@victorbjelkholm Thank you! Just updated to

image

@daviddias
Copy link
Member Author

@victorbjelkholm would you like to have the honor to review this PR so that I can merge it ? :)

@victorb
Copy link
Member

victorb commented Apr 30, 2018

Awesome, looks good!

victorb
victorb previously approved these changes Apr 30, 2018
@victorb
Copy link
Member

victorb commented Apr 30, 2018

The target branch requires all commits to be signed. Learn more about signing commits.

Working well for this repo at least! :)

@daviddias
Copy link
Member Author

@victorbjelkholm you'll need to approve again

@daviddias daviddias requested a review from victorb April 30, 2018 14:09
@vmx
Copy link
Member

vmx commented May 4, 2018

@diasdavid The screenshot shows that "Require signed commits: Commits pushed to this branch must have verified signatures." is ticked. Is that intentional and a must?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants