-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
This is the first PR towards the goal of ipfs/community#301 (comment) I've updated the permissions of this repo to I believe these restrictions to be sane, but would like someone to double check. |
The "require status checks to pass before merging" option needs to have a status check that is marked as required, otherwise this option does nothing. Should probably be the I think "Restrict who can push to this branch" should be activated and no one should be allowed to push directly to master. From the screenshot, you'll be able to push but no one else. |
@victorbjelkholm Thank you! Just updated to |
@victorbjelkholm would you like to have the honor to review this PR so that I can merge it ? :) |
Awesome, looks good! |
Working well for this repo at least! :) |
2cef443
to
33da796
Compare
@victorbjelkholm you'll need to approve again |
@diasdavid The screenshot shows that "Require signed commits: Commits pushed to this branch must have verified signatures." is ticked. Is that intentional and a must? |
ref: ipfs/community#301 (comment)