feat: add sha1 support #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
approved these changes
May 29, 2023
rvagg
approved these changes
May 29, 2023
Closed
|
Taking another look at this and was considering being more firm in saying no but I realise now that the dependency introduced here is a devDependency and you're using SubtleCrypto to do the work here. So I guess this isn't that bad after all. @achingbrain if you need it, feel free to push it through and release. |
It's old and insecure but it's used in the wild so we need to be able to handle it.
rvagg
force-pushed
the
feat/add-sha1-support
branch
from
7d5a43b
to
6a78612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's old and insecure but it's used in the wild so we need to be able to handle it.