Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

Implement base36 #53

Closed
hugomrdias opened this issue May 22, 2020 · 1 comment · Fixed by #55
Closed

Implement base36 #53

hugomrdias opened this issue May 22, 2020 · 1 comment · Fixed by #55
Assignees
@hugomrdias
Labels
exp/novice Someone with a little familiarity can pick up P0 Critical: Tackled by core team ASAP

Comments

@hugomrdias
Copy link
Member

hugomrdias commented May 22, 2020 •
edited
Loading

multiformats/multibase#65

refs:
multiformats/cid-utils-website#23 (comment)
@hugomrdias hugomrdias self-assigned this May 22, 2020
@hugomrdias hugomrdias added exp/novice Someone with a little familiarity can pick up P0 Critical: Tackled by core team ASAP labels May 22, 2020
@hugomrdias hugomrdias mentioned this issue May 22, 2020
Merged
@ribasushi
Copy link

@hugomrdias if of any help in js/wasm-land: https://github.com/multiformats/go-base36/blob/11f3b26a8e0e9068d38d6fa365d487dd00c6d057/base36.go

@hugomrdias hugomrdias mentioned this issue Jun 3, 2020
Merged
hugomrdias added a commit that referenced this issue Jun 9, 2020
@hugomrdias
feat: more encoding, errors, spec tests (#55)
613363b 
- adds support for all the encodings in https://github.com/multiformats/multibase/blob/master/multibase.csv
-  better errors showing the invalid chars and inputs
- `names` and `codes` exports the full object that maps names/codes to base instances
  - you can use these to get the unprefixed base encoder/decoder
- two new methods exported, `encoding` and `encodingFromData`
  - you can use these to get the unprefixed base encoder/decoder
- adds all the spec tests https://github.com/multiformats/multibase/tree/master/tests
- its also faster check benchmarks below

This module now only uses 2 base encoding implementations, 1 generalised rfc4648 and 1 generalised btc like.

closes #49 
closes #38 
closes #46
closes #53
closes #26 

BREAKING CHANGE: `names` and `codes` export the full object that maps names/codes to base instances instead of just the keys
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hugomrdias hugomrdias

Labels
exp/novice Someone with a little familiarity can pick up P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: more encoding, errors, spec tests multiformats/js-multibase
2 participants
@hugomrdias @ribasushi