Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: integrate with aegir types cmd #159
fix: integrate with aegir types cmd #159
Changes from all commits
678341b
8bf9cae
708292c
4cec873
449065d
7251ac9
9a853c2
a09e829
04e0b48
980973d
df5ab2a
64d1aed
f30a721
f5cb727
26bf0ee
c83f1c1
89966e5
89766b0
50719b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make more sense to have
Multiaddr.parse(string)
static and make constructor@private
. That way this turns intoAnd if we really want to smooth out transition we could have deprecated alias
multiaddr
.My argument for discouraging
new Multiadddr
is because has tendency to grow intonew Multiaddr(any)
over time.My personal opinion is to reserve constructors for property initializations, all the computation and logic should go into dedicated functions.
Edit: Added more details in the contstructor
This file was deleted.