fix: use multibase and add buffer #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds buffer related to ipfs/js-ipfs#2924 Uses multibase to encode.
56 tasks
jacobheun
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Just suggested two minor comments to clarify prepending b before decoding the onion addresses, but this looks good.
Ideally I think multibase should expose an api, similar to encode, where you can pass the base name (or access the base directly) but that's a separate issue.
Co-Authored-By: Jacob Heun <[email protected]>
Co-Authored-By: Jacob Heun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds buffer related to ipfs/js-ipfs#2924
Uses multibase to encode.
Remove ip dep, copied some code from it.
ipdepends onosfor things we don't need.